Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Issue 246 fix, type hints for object schema dict output class values improved #252

Merged
merged 11 commits into from
Oct 16, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 12, 2023

Issue 246 fix

  • converts ApiResponses back to dataclasses to fix mypy errors when accessing properties in them
    • removes defaults except for ApiResponseWithoutDeserialization
  • removed format property from schemaType CodegenSchema
  • makes schema addition use the most permissive information because addition is used to generate mapValueSchema
  • adds java tests of mapValueSchema.types which the python code uses to determine if casting is needed for properties

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether merged commit 208b7cb into master Oct 16, 2023
@spacether spacether deleted the issue_246_fix branch October 16, 2023 18:13
@spacether spacether changed the title Issue 246 fix Issue 246 fix, type hints for object schema dict output class values improved Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][python] get user's mypy check passing with warn_redundant_casts turned on
1 participant