Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Adds 3.1.0 unit test spec #238

Merged
merged 21 commits into from
Sep 15, 2023
Merged

Adds 3.1.0 unit test spec #238

merged 21 commits into from
Sep 15, 2023

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Sep 14, 2023

Adds 310 unit test spec

  • only v3.0.3 json schema keywords have been turned on at this time. A future PR will turn on the new v3.1.0 json schema keywords + tests
  • type array cases included
  • Note: draft2020-12 requires that format validation is opt out by default. My expectation is that in code generation contexts, format validation is opt-in by default. So I keep the code opting in to validation on format by default, in in tests, I opt the tests out of format validation. End users may turn off format validation like the tests do if they prefer.

swagger-parser bugs found:

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/python*.
    For Windows users, please run the script in Git BASH.

@spacether spacether marked this pull request as draft September 14, 2023 18:18
@spacether spacether changed the title Adds 310 unit test spec Adds 3.1.0 unit test spec Sep 15, 2023
@spacether spacether marked this pull request as ready for review September 15, 2023 22:26
@spacether spacether merged commit 605f380 into master Sep 15, 2023
@spacether spacether deleted the feat_adds_310_spec branch September 15, 2023 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant