This repository was archived by the owner on Dec 25, 2024. It is now read-only.
Adds XSchemaDict constructor using named arguments #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
added a commit
that referenced
this pull request
Aug 16, 2023
* Adds from_dict_ method * Adds immutabledict back in * Adds types for required and optional properties * Uses new io_type template for required and optional properties * Adds newlines to boolean input types * Adds newlines to binary and none * Adds newline for literal values * Adds newline for optional str * Adds newlines for number and integer inputs * Adds remaining io newlines * Adds input types to anyType input * Adds map with no props types * Adds object input types * Adds tuple types when there is not arrayOutputJsonPathPiece * Adds array input types * Adds arg casting when addProps is false * Adds casting to object model input in new method * Adds new types for kwargs * Makes arg_ dict type permissive * Adds _arg dict type in new * Replaces _helper_property_value_type with _helper_schema_io_type in object_input_type * Replaces many _helper_property_value_type usages * Uses schema_io for optional property definition * Updates required properties typeddict to use schema_io template * Adjusts definition of array model type to use schema_io template * Removes unused templates * Fixes array model self reference detection * Fixes mypy errors by making default literals into literals * Adjusts comment line for empty map output class * Fixes mypy errors by moving new before properties * Requires that required arguments are named and not positional * Adds date/datetime/uuid inputs when those formats are specified * Removes reference to deleted input schema template * Adds io. types for binary input * Samples regen * Changes node4 image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developers want to make an instance of an object payload they can currently input a typeddict as an input argument.
Previously, they could input named arguments to create an instance too.
For SomeSchemaDict type object output classes, this PR adds that functionality back in where one can pass in named arguments to
SomeSchemaDict.__new____new__+ from_dict_)Note
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/python*.For Windows users, please run the script in Git BASH.