This repository was archived by the owner on Dec 25, 2024. It is now read-only.
Shortens operation + response files, improves request body serialize typing #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fn implementation signature
spacether
changed the title
spacether
changed the title
spacether
added a commit
that referenced
this pull request
Aug 16, 2023
…typing (#195) * Generates separate file for pathparameters * Adds x_parameters files * Fixes typo * Passes body_info into _get_fields_and_body * Adds RequestBodyInfo ref linking * Fixes body types in BodyInfoForX * Fixes one python test * Fixes one test * Fixes another test * Fixes test_body_with_query_params * Fixes test_composed_one_of_different_types * Fixes test_inline_composition * Fixes test_json_patch * Fixes test_json_with_charset * Fixes test_mammal, test_missing_or_unset_required_body * Fixes two tests * Fixes two tests * Fixes two tests * Fixes two tests * Fixes last python test * Allows body_info to be None * Adds request_body imports for endpoint code sample * Adds body_info to endpoint docs * Stops generating requestbodyinfo schemas for refed schemas * Dereferences request body schemas * Improves refModuleAlias values, prevents collisions based on usages * Samples regenerated * Samples actually regenerated * Fixes test for the nonCOmpliantDiscriminator sample * Fixes unit tests * Runs ensure up to date * Adds content type back in * Adds content type overload condition branch * Adds per content type operation overloads * Removes unused getContentTypeToOperation, adds requestBodySchema * Adds and sets requestBodySchema in CodegenOperation * Uses a linkedhashmap to store properties before making requestBodySchema * Uses requestBodySchema.properties to define type hints for operation fn implementation signature * Adds request body schema imports at the top of the operation file * Adds body type hints for operation * Switches code back to using body + content_type * FIxes two tests * Runs black on file, fixes three tests * Fixes 3 tests * Fixes 3 more tests * Updates operation variable names * Fixes body schema input type to use refModuleAlias, samples regen * FIxes unitt est specs * Updates templates to remove RequestBodyInfo * Samples regenerated * Updates operation to directly import query cookie header path param schema classes * Sets skip_validation to True in _get_used_path * FIxes mypy type errors, improves request body typing * Samples regen * Fixes typo * Removes unused doc import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/python*.For Windows users, please run the script in Git BASH.