This repository was archived by the owner on Dec 25, 2024. It is now read-only.
Updates __new__ to take one arg input #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andreqproperties exist
spacether
added a commit
that referenced
this pull request
Aug 16, 2023
* Adds section for required property type writing * Adds required property classes * Adds template adjustment for optional properties * Adds template to write optional properties typeddict * Successfully generates required and optional typeddicts * Writes DictInput class to store required and optional input properties * Changes new dict inptut type for arg_ and changes args_* to arg_ * Update new signature * Removes unsets from optional properties, allows self in when optionalandreqproperties exist * Typeddicts only generated when addProps is false * Tweaks when reqanoptprops are generated * Adds types to dictchema input * Adds many use cases object inputs * Adds req property mapping writing when addprops set * Adds last required object type definition * Fixes allAreInline for DictInput * Adds optional properties type hint when addProps unset * Adds and uses new partial * Adds mapping type for required + opt + addProps * Writes all property input mapping types * Updates new signature to use DictInput for all object use cases * Updates 3 test files * Fixes more python tests * Fixes manual tests * Fixes python tests * Converts example properties into example keys, fixes schema naming bug * Adds braces aroudn object input * Fixes example addProp key * arg_ -> arg * Schema input configuration_ -> configuration * Removes 'from_openapi_data_' * Fixes java tests * Samples regenerated * Unit test sample updated * Fixes bug with allof/anyOf/oneOf type names * Fixes python non compliant discriminator test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__new__uses only one arg inputFuture
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/python*.For Windows users, please run the script in Git BASH.