This repository was archived by the owner on Dec 25, 2024. It is now read-only.
v3 reduce typing overloads #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacether
added a commit
that referenced
this pull request
May 17, 2023
* Removes overrides from api classes * Fixes type hint for operation methods, reduced 2x duplication * Samples updated * Sample regen
spacether
added a commit
that referenced
this pull request
May 31, 2023
* Removes overrides from api classes * Fixes type hint for operation methods, reduced 2x duplication * Samples updated * Sample regen
spacether
added a commit
that referenced
this pull request
Jun 8, 2023
* Removes overrides from api classes * Fixes type hint for operation methods, reduced 2x duplication * Samples updated * Sample regen
spacether
added a commit
that referenced
this pull request
Aug 16, 2023
* Removes overrides from api classes * Fixes type hint for operation methods, reduced 2x duplication * Samples updated * Sample regen
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduces code qty by eliminating redundant operation overloads
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/python*.For Windows users, please run the script in Git BASH.