fix: include period as known delimiter #546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An actual live example of period being a valid known delimiter is when using
protoc
and producing OpenApi2 with fully qualified names on. See here. The names generated from the protocol buffers will be of the formprotoname.v1.MessageName
.Without this change, the processed name would be
Protonamev1MessageName
and the model filename would beprotonamev_1_message_name.py
. With the change, it'sProtonameV1MessageName
andprotoname_v1_message_name.py
, respectively.Tests included for
utils.sanitize
andutils.split_words
as well as an e2e test for a model with periods in the reference name.