Skip to content

Revert "build: Include a basic setup.py to allow editable installs during development (#370)" #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

ramnes
Copy link
Contributor

@ramnes ramnes commented Apr 1, 2021

It seems that hings are more complicated than that. This shim setup.py does
allow the project to be pip -e installed but you don't get the entrypoints,
making it completely useless.

This reverts commit 915183d.

…ring development (openapi-generators#370)"

It seems that hings are more complicated than that. This shim setup.py does
allow the project to be pip -e installed but you don't get the entrypoints,
making it completely useless.

This reverts commit 915183d.
@ramnes
Copy link
Contributor Author

ramnes commented Apr 1, 2021

Sorry for the noise. :(

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #374 (2cfc448) into main (915183d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #374   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1483      1483           
=========================================
  Hits          1483      1483           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 915183d...2cfc448. Read the comment docs.

@dbanty
Copy link
Collaborator

dbanty commented Apr 1, 2021

Sorry to hear that 😕. I've done a bit of searching for ways to editable-install Poetry projects and it seems the only supported way is by using Poetry itself to manage whatever environment you're installing it to. It's possible to generate a fully-complete setup.py from the pyproject.toml but we'd have to find a way to automate keeping it up to date. Maybe with a periodic GitHub Action or something?

@dbanty dbanty merged commit f3aa0b0 into openapi-generators:main Apr 1, 2021
@ramnes
Copy link
Contributor Author

ramnes commented Apr 1, 2021

Sounds quite overkill to me, alas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants