Skip to content

docs: Need to run task regen_custom #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2021

Conversation

csymeonides-mf
Copy link
Contributor

@csymeonides-mf csymeonides-mf commented Mar 19, 2021

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #352 (aec43be) into main (ab6aec6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1420      1420           
=========================================
  Hits          1420      1420           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6aec6...aec43be. Read the comment docs.

@dbanty
Copy link
Collaborator

dbanty commented Mar 20, 2021

Awesome, thanks for the update. I tend to use task re which regens both records and runs the e2e tests immediately. Do you think it's worth including a note about that as well?

@csymeonides-mf
Copy link
Contributor Author

Awesome, thanks for the update. I tend to use task re which regens both records and runs the e2e tests immediately. Do you think it's worth including a note about that as well?

Sure, will do

@dbanty
Copy link
Collaborator

dbanty commented Mar 20, 2021

Honestly having a whole separate e2e test for custom is probably unnecessary and more than a little annoying 😅. So I might just rework that test instead to only test the use of the custom template (rather than comparing the whole directory).

Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! Like I said I think I need to revisit the e2e process overall but at least now the docs are up to date until I do that!

@dbanty dbanty merged commit 89b4d41 into openapi-generators:main Mar 20, 2021
@csymeonides-mf csymeonides-mf deleted the patch-1 branch March 20, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants