Skip to content

feat: Add extra template arguments option #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alexifm
Copy link
Contributor

@alexifm alexifm commented Mar 10, 2021

This is draft to propose adding an option for passing extra arguments to the jinja templates based on the comment here: #224 (comment)

Still requires tests and formatting/cleanup but feedback on if there is interest in this and it's taking the right approach would be appreciated.

@dbanty
Copy link
Collaborator

dbanty commented Mar 13, 2021

I'm not totally clear on what the use-case is for kwargs like that? They're effectively hard-coded values, so why not just include them in the custom template you're using? I assume there's just something here I'm missing 😅.

If we were to do this, I think it makes more sense to put it in the config file since you could use YAML/JSON object notation instead of us having to parse from command line. That sort of depends on how these would be used though I guess.

@dbanty
Copy link
Collaborator

dbanty commented Oct 17, 2021

Closing since this is kind of stale, but happy to revisit the idea at some point if this is needed.

@dbanty dbanty closed this Oct 17, 2021
@alexifm alexifm deleted the feat/template-args branch December 17, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants