Better compatibility for "required" vs. "nullable" #230
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| from typing import Any, Dict, List, Optional, Union, cast | ||
|
|
||
| import httpx | ||
|
|
||
| from ...client import Client | ||
| from ...models.http_validation_error import HTTPValidationError | ||
| from ...types import UNSET, Response, Unset | ||
|
|
||
|
|
||
| def _get_kwargs( | ||
| *, | ||
| client: Client, | ||
| query_param: Union[Unset, List[str]] = UNSET, | ||
| ) -> Dict[str, Any]: | ||
| url = "{}/tests/optional_query_param/".format(client.base_url) | ||
|
|
||
| headers: Dict[str, Any] = client.get_headers() | ||
|
|
||
| json_query_param: Union[Unset, List[Any]] = UNSET | ||
| if not isinstance(query_param, Unset): | ||
| json_query_param = query_param | ||
|
|
||
| params: Dict[str, Any] = {} | ||
| if query_param is not UNSET: | ||
| params["query_param"] = json_query_param | ||
|
|
||
| return { | ||
| "url": url, | ||
| "headers": headers, | ||
| "cookies": client.get_cookies(), | ||
| "timeout": client.get_timeout(), | ||
| "params": params, | ||
| } | ||
|
|
||
|
|
||
| def _parse_response(*, response: httpx.Response) -> Optional[Union[None, HTTPValidationError]]: | ||
| if response.status_code == 200: | ||
| return None | ||
| if response.status_code == 422: | ||
| return HTTPValidationError.from_dict(cast(Dict[str, Any], response.json())) | ||
| return None | ||
|
|
||
|
|
||
| def _build_response(*, response: httpx.Response) -> Response[Union[None, HTTPValidationError]]: | ||
| return Response( | ||
| status_code=response.status_code, | ||
| content=response.content, | ||
| headers=response.headers, | ||
| parsed=_parse_response(response=response), | ||
| ) | ||
|
|
||
|
|
||
| def sync_detailed( | ||
| *, | ||
| client: Client, | ||
| query_param: Union[Unset, List[str]] = UNSET, | ||
| ) -> Response[Union[None, HTTPValidationError]]: | ||
| kwargs = _get_kwargs( | ||
| client=client, | ||
| query_param=query_param, | ||
| ) | ||
|
|
||
| response = httpx.get( | ||
| **kwargs, | ||
| ) | ||
|
|
||
| return _build_response(response=response) | ||
|
|
||
|
|
||
| def sync( | ||
| *, | ||
| client: Client, | ||
| query_param: Union[Unset, List[str]] = UNSET, | ||
| ) -> Optional[Union[None, HTTPValidationError]]: | ||
| """ Test optional query parameters """ | ||
|
|
||
| return sync_detailed( | ||
| client=client, | ||
| query_param=query_param, | ||
| ).parsed | ||
|
|
||
|
|
||
| async def asyncio_detailed( | ||
| *, | ||
| client: Client, | ||
| query_param: Union[Unset, List[str]] = UNSET, | ||
| ) -> Response[Union[None, HTTPValidationError]]: | ||
| kwargs = _get_kwargs( | ||
| client=client, | ||
| query_param=query_param, | ||
| ) | ||
|
|
||
| async with httpx.AsyncClient() as _client: | ||
| response = await _client.get(**kwargs) | ||
|
|
||
| return _build_response(response=response) | ||
|
|
||
|
|
||
| async def asyncio( | ||
| *, | ||
| client: Client, | ||
| query_param: Union[Unset, List[str]] = UNSET, | ||
| ) -> Optional[Union[None, HTTPValidationError]]: | ||
| """ Test optional query parameters """ | ||
|
|
||
| return ( | ||
| await asyncio_detailed( | ||
| client=client, | ||
| query_param=query_param, | ||
| ) | ||
| ).parsed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to handle nested unions better. I wonder if there's a function in typing somewhere that can simplify types like this. Not necessary for this PR but would be a good future enhancement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think manually adding Unset to the union should work fine, I'll give that a shot