Skip to content

Fix minimum attrs version #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/fix_minimum_attrs_version.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
default: patch
---

# Fix minimum `attrs` version

The minimum `attrs` dependency version was incorrectly set to 21.3.0. This has been corrected to 22.2.0, the minimum
supported version since `openapi-python-client` 0.19.1.

Closes #1084, thanks @astralblue!
2 changes: 1 addition & 1 deletion end_to_end_tests/golden-record/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ include = ["CHANGELOG.md", "my_test_api_client/py.typed"]
[tool.poetry.dependencies]
python = "^3.9"
httpx = ">=0.20.0,<0.29.0"
attrs = ">=21.3.0"
attrs = ">=22.2.0"
python-dateutil = "^2.8.0"

[build-system]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ include = ["CHANGELOG.md", "my_enum_api_client/py.typed"]
[tool.poetry.dependencies]
python = "^3.9"
httpx = ">=0.20.0,<0.29.0"
attrs = ">=21.3.0"
attrs = ">=22.2.0"
python-dateutil = "^2.8.0"

[build-system]
Expand Down
2 changes: 1 addition & 1 deletion end_to_end_tests/metadata_snapshots/pdm.pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ readme = "README.md"
requires-python = ">=3.9,<4.0"
dependencies = [
"httpx>=0.20.0,<0.29.0",
"attrs>=21.3.0",
"attrs>=22.2.0",
"python-dateutil>=2.8.0",
]

Expand Down
2 changes: 1 addition & 1 deletion end_to_end_tests/metadata_snapshots/poetry.pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ include = ["CHANGELOG.md", "test_3_1_features_client/py.typed"]
[tool.poetry.dependencies]
python = "^3.9"
httpx = ">=0.20.0,<0.29.0"
attrs = ">=21.3.0"
attrs = ">=22.2.0"
python-dateutil = "^2.8.0"

[build-system]
Expand Down
2 changes: 1 addition & 1 deletion end_to_end_tests/metadata_snapshots/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
long_description_content_type="text/markdown",
packages=find_packages(),
python_requires=">=3.9, <4",
install_requires=["httpx >= 0.20.0, < 0.29.0", "attrs >= 21.3.0", "python-dateutil >= 2.8.0, < 3"],
install_requires=["httpx >= 0.20.0, < 0.29.0", "attrs >= 22.2.0", "python-dateutil >= 2.8.0, < 3"],
package_data={"test_3_1_features_client": ["py.typed"]},
)
2 changes: 1 addition & 1 deletion end_to_end_tests/test-3-1-golden-record/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ include = ["CHANGELOG.md", "test_3_1_features_client/py.typed"]
[tool.poetry.dependencies]
python = "^3.9"
httpx = ">=0.20.0,<0.29.0"
attrs = ">=21.3.0"
attrs = ">=22.2.0"
python-dateutil = "^2.8.0"

[build-system]
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ readme = "README.md"
requires-python = ">=3.9,<4.0"
dependencies = [
"httpx>=0.20.0,<0.29.0",
"attrs>=21.3.0",
"attrs>=22.2.0",
"python-dateutil>=2.8.0",
]

Expand Down
4 changes: 2 additions & 2 deletions openapi_python_client/templates/pyproject.toml.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ include = ["CHANGELOG.md", "{{ package_name }}/py.typed"]
{% if pdm %}
dependencies = [
"httpx>=0.20.0,<0.29.0",
"attrs>=21.3.0",
"attrs>=22.2.0",
"python-dateutil>=2.8.0",
]

Expand All @@ -32,7 +32,7 @@ distribution = true
[tool.poetry.dependencies]
python = "^3.9"
httpx = ">=0.20.0,<0.29.0"
attrs = ">=21.3.0"
attrs = ">=22.2.0"
python-dateutil = "^2.8.0"
{% endif %}

Expand Down
2 changes: 1 addition & 1 deletion openapi_python_client/templates/setup.py.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ setup(
long_description_content_type="text/markdown",
packages=find_packages(),
python_requires=">=3.9, <4",
install_requires=["httpx >= 0.20.0, < 0.29.0", "attrs >= 21.3.0", "python-dateutil >= 2.8.0, < 3"],
install_requires=["httpx >= 0.20.0, < 0.29.0", "attrs >= 22.2.0", "python-dateutil >= 2.8.0, < 3"],
package_data={"{{ package_name }}": ["py.typed"]},
)
2 changes: 1 addition & 1 deletion pdm.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions pdm.minimal.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
groups = ["default", "dev"]
strategy = ["direct_minimal_versions", "inherit_metadata"]
lock_version = "4.5.0"
content_hash = "sha256:50f45ddc1fe2529d12869f3f378bf09b25166e6c66cdf84f1c32db1cbe43ff8c"
content_hash = "sha256:7f8035cfb12eec0bca9053eb34cc6b70a1cfbf464921c1abb3ae3c3e63cfeab4"

[[metadata.targets]]
requires_python = "~=3.9"
Expand Down Expand Up @@ -43,13 +43,13 @@ files = [

[[package]]
name = "attrs"
version = "21.3.0"
requires_python = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*"
version = "22.2.0"
requires_python = ">=3.6"
summary = "Classes Without Boilerplate"
groups = ["default"]
files = [
{file = "attrs-21.3.0-py2.py3-none-any.whl", hash = "sha256:8f7335278dedd26b58c38e006338242cc0977f06d51579b2b8b87b9b33bff66c"},
{file = "attrs-21.3.0.tar.gz", hash = "sha256:50f3c9b216dc9021042f71b392859a773b904ce1a029077f58f6598272432045"},
{file = "attrs-22.2.0-py3-none-any.whl", hash = "sha256:29e95c7f6778868dbd49170f98f8818f78f3dc5e0e37c0b1f474e3561b240836"},
{file = "attrs-22.2.0.tar.gz", hash = "sha256:c9227bfc2f01993c03f68db37d1d15c9690188323c067c641f1a35ca58185f99"},
]

[[package]]
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies = [
"colorama>=0.4.3; sys_platform == \"win32\"",
"shellingham>=1.3.2,<2.0.0",
"pydantic>=2.1.1,<3.0.0",
"attrs>=21.3.0",
"attrs>=22.2.0",
"python-dateutil>=2.8.1,<3.0.0",
"httpx>=0.20.0,<0.29.0",
"ruamel.yaml>=0.18.6,<0.19.0",
Expand Down
Loading