fix: import cast for required const properties, since it's used in the template #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, if you wouldn't mind adding a test so we can prevent this from regressing in the future, that'd be great! |
benweint
force-pushed
the
import-cast-when-needed
branch
from
0a0671b to
4ce002e
Compare
|
Sure thing, added a test case to both of these files and regenerated baselines:
(If that's not the right place for these tests, let me know what you think would be a better home!) |
dbanty
approved these changes
Oct 28, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 23, 2024
> [!IMPORTANT] > Merging this pull request will create this release ## Fixes - allow required fields list to be specified as empty (#651) (#1149) - import cast for required const properties, since it's used in the template (#1153) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
micha91
pushed a commit
to micha91/openapi-python-client
that referenced
this pull request
May 13, 2025
…e template (openapi-generators#1153) The [template](https://github.com/openapi-generators/openapi-python-client/blob/main/openapi_python_client/templates/property_templates/const_property.py.jinja#L2) for `const` properties uses `cast` unconditionally, but the import for `cast` in `ConstProperty.get_imports` was conditioned on whether the property was required or not, leading to broken generated code for required const properties. I'd be happy to add a test for this if desired! A cursory glance suggests that maybe the end_to_end tests would be the right place? Resolves openapi-generators#1150
micha91
pushed a commit
to micha91/openapi-python-client
that referenced
this pull request
May 13, 2025
> [!IMPORTANT] > Merging this pull request will create this release ## Fixes - allow required fields list to be specified as empty (openapi-generators#651) (openapi-generators#1149) - import cast for required const properties, since it's used in the template (openapi-generators#1153) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template for
constproperties usescastunconditionally, but the import forcastinConstProperty.get_importswas conditioned on whether the property was required or not, leading to broken generated code for required const properties.I'd be happy to add a test for this if desired! A cursory glance suggests that maybe the end_to_end tests would be the right place?
Resolves #1150