Skip to content

fix timeout issue with a pause on retry #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mtmahe
Copy link

@mtmahe mtmahe commented Dec 7, 2023

  • [x ] I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

When running embedding models in azure to create vector indexes there is a timeout even with ADA set to 240 TPM. Simply adding a 10s sleep (only on retry attempts) fixes this.

Thank you so much for all your amazing work!

Additional context & links

@mtmahe mtmahe requested a review from a team as a code owner December 7, 2023 20:03
@slyapustin
Copy link

@mtmahe Any specific reason why it's set to 10 seconds?

@rattrayalex rattrayalex added the Azure for issues relating to the Azure OpenAI service label Dec 11, 2023
@rattrayalex
Copy link
Collaborator

@mtmahe – unfortunately this change would add a sleep to all retried requests, not just the ones you are looking to fix, so we cannot accept this change.

cc @kristapratico – sending a retry-after header from the azure API here might be helpful.

@mtmahe
Copy link
Author

mtmahe commented Dec 11, 2023

Hi @rattrayalex

Thanks for consider my request. Yes, a retry-after should work.

@kristapratico
Copy link
Contributor

cc @kristapratico – sending a retry-after header from the azure API here might be helpful.

The Azure embeddings API does return a Retry-After header. There was a bug in the past week where this header wasn't being returned in the response, but it should be restored now. Let us know if the issue persists for you @mtmahe

stainless-app bot added a commit that referenced this pull request Mar 27, 2025
stainless-app bot added a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure for issues relating to the Azure OpenAI service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants