Running mypy on sdk resources #773 #4360
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -61,6 +61,7 @@ def _handle(self, error: Exception, *args, **kwargs): | |||||
|
|
||||||
| from abc import ABC, abstractmethod | ||||||
| from logging import getLogger | ||||||
| from typing import Optional | ||||||
|
There was a problem hiding this comment. I'd rather prefer to use |
||||||
|
|
||||||
| from opentelemetry.util._importlib_metadata import entry_points | ||||||
|
|
||||||
|
|
@@ -69,7 +70,7 @@ def _handle(self, error: Exception, *args, **kwargs): | |||||
|
|
||||||
| class ErrorHandler(ABC): | ||||||
| @abstractmethod | ||||||
| def _handle(self, error: Exception, *args, **kwargs) -> None: # type: ignore | ||||||
| """ | ||||||
| Handle an exception | ||||||
| """ | ||||||
|
|
@@ -83,7 +84,7 @@ class _DefaultErrorHandler(ErrorHandler): | |||||
| """ | ||||||
|
|
||||||
| # pylint: disable=useless-return | ||||||
| def _handle(self, error: Exception, *args, **kwargs) -> None: # type: ignore | ||||||
| logger.exception("Error handled by default error handler: ") | ||||||
| return None | ||||||
|
|
||||||
|
|
@@ -105,26 +106,26 @@ def __new__(cls) -> "GlobalErrorHandler": | |||||
|
|
||||||
| return cls._instance | ||||||
|
|
||||||
| def __enter__(self) -> None: | ||||||
| pass | ||||||
|
|
||||||
| # pylint: disable=no-self-use | ||||||
| def __exit__(self, exc_type, exc_value, traceback) -> Optional[bool]: # type: ignore | ||||||
| if exc_value is None: # type: ignore | ||||||
|
There was a problem hiding this comment. If above applied, the ignore is not needed.
Suggested change
|
||||||
| return None | ||||||
|
|
||||||
| plugin_handled = False | ||||||
|
|
||||||
| error_handler_entry_points = entry_points( # type: ignore | ||||||
|
There was a problem hiding this comment. This can be typed, https://github.com/python/importlib_metadata/blob/main/importlib_metadata/__init__.py#L1039C42-L1039C43 There was a problem hiding this comment. There was a problem hiding this comment. basedpyright: Import "opentelemetry.util._importlib_metadata" could not be resolved. This results in following errors when mypy is executed - opentelemetry-sdk/src/opentelemetry/sdk/error_handler/init.py:119: error: Type of variable becomes "Any" due to an unfollowed import [no-any-unimported] There was a problem hiding this comment. @xrmx Please let me know if the above errors can be handled differently. There was a problem hiding this comment. I mean something like this There was a problem hiding this comment. This PR has more type ignores than actual typing improvements. There was a problem hiding this comment. This is a tricky one to type hint because of the way https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py is implemented. There was a problem hiding this comment. @Kludex do you have any suggestions? There was a problem hiding this comment. This PR is really only adding There was a problem hiding this comment. My suggestion is for the project to fix the mypy setup in this project, or move to pyright. I'm happy to help, if the maintainers are willing. If you can help, please create an issue about the mypy setup. |
||||||
| group="opentelemetry_error_handler" | ||||||
| ) | ||||||
|
|
||||||
| for error_handler_entry_point in error_handler_entry_points: # type: ignore | ||||||
| error_handler_class = error_handler_entry_point.load() # type: ignore | ||||||
|
|
||||||
| if issubclass(error_handler_class, exc_value.__class__): # type: ignore | ||||||
| try: | ||||||
| error_handler_class()._handle(exc_value) # type: ignore | ||||||
| plugin_handled = True | ||||||
|
|
||||||
| # pylint: disable=broad-exception-caught | ||||||
|
|
@@ -133,11 +134,11 @@ def __exit__(self, exc_type, exc_value, traceback): | |||||
| "%s error while handling error" | ||||||
| " %s by error handler %s", | ||||||
| error_handling_error.__class__.__name__, | ||||||
| exc_value.__class__.__name__, # type: ignore | ||||||
| error_handler_class.__name__, # type: ignore | ||||||
| ) | ||||||
|
|
||||||
| if not plugin_handled: | ||||||
| _DefaultErrorHandler()._handle(exc_value) # type: ignore | ||||||
|
|
||||||
| return True | ||||||
Uh oh!
There was an error while loading. Please reload this page.