Skip to content

Shutting down exporters before calling threads.join() #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rajat315315
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3309

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rajat315315 rajat315315 requested a review from a team July 19, 2023 12:59
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @rajat315315, we do need at least one test that shows this change has the intended effect.

Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a bugfix, please add an entry in the CHANGELOG file.

self.span_exporter.shutdown()
self.worker_thread.join()
Copy link
Contributor

@lzchen lzchen Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something here but isn't there reason we join before shutting down is because we want to wait for all the current telemetry in the queue to be exported before shutting down the exporter? Wouldn't we drop those pieces of telemetry if we switched the order?

@lzchen
Copy link
Contributor

lzchen commented Sep 28, 2023

@rajat315315

Are you still working on this?

@ocelotl
Copy link
Contributor

ocelotl commented Oct 5, 2023

@rajat315315 we are closing this PR since we haven't received a reply in a while. Please reopen if you being work on it again.

@ocelotl ocelotl closed this Oct 5, 2023
@brightsparc
Copy link

This is still an issue, can we re-open this and work on landing this fix?

@lzchen
Copy link
Contributor

lzchen commented Nov 2, 2023

@brightsparc

It doesn't look like the original author is working on this anymore. Feel to free to open a pr if you want this to be addressed asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporters shutdown takes longer then a minute when failing to send metrics/traces
4 participants