refactor(flask): replace SpanAttributes with semconv attributes #3539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋 Just wanted to kindly follow up. This PR replaces deprecated All changes were tested locally and verified against the existing test suite. Please let me know if anything should be adjusted or improved — happy to iterate! Thanks for your time and for maintaining this project 🙏 |
xrmx
approved these changes
May 23, 2025
…nto refactor-flask-spanattributes
xrmx
reviewed
May 23, 2025
| @@ -273,12 +273,14 @@ def response_hook(span: Span, status: str, response_headers: List): | |||
| ) | |||
| from opentelemetry.instrumentation.utils import _start_internal_or_server_span | |||
| from opentelemetry.metrics import get_meter | |||
| from opentelemetry.semconv.attributes.http_attributes import HTTP_ROUTE | |||
There was a problem hiding this comment.
I would keep using the stable one, no need to update the tests import to match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces deprecated usage of
SpanAttributeswith semantic convention attributes fromopentelemetry.semconv.attributesin theopentelemetry-instrumentation-flaskpackage.These changes bring the Flask instrumentation module in line with current OpenTelemetry conventions and help modernize the codebase as part of the broader refactoring tracked in the issue below.
Refs #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
pytestforinstrumentation/opentelemetry-instrumentation-flask/tests/SpanAttributesremainDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.