-
Notifications
You must be signed in to change notification settings - Fork 18
feat: Add Flipt provider #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: atmask <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just curious if this gives end users much over the generic Python OFREP impl? Is the end goal of OFREP to make it easier to implement provider specific sdks or to be 'the' SDK for all providers that support it?
cc @beeme1mr
providers/openfeature-provider-flipt/src/openfeature/contrib/provider/flipt/__init__.py
Show resolved
Hide resolved
I'm fine with the OFREP provider being extended to make it work more seamlessly. It's really up to you and Mark. I believe Flipt also has an SDK that supports in-process evaluation. That would likely be a more performant option. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 94.39% 94.65% +0.26%
==========================================
Files 14 14
Lines 749 749
==========================================
+ Hits 707 709 +2
+ Misses 42 40 -2 ☔ View full report in Codecov by Sentry. |
@beeme1mr kk, sounds good. I'll leave that ask up to @markphelps to give direction on. I had thought of wrapping around the existing Python SDK for Flipt but OFREP seemed quicker and easier option to get support out (I'd like to be able to consume this api). I can re-work it but it'll just take some more time to re-write the implementation |
@atmask lgtm! thank you!! we do have an inprocess evaluator like @beeme1mr mentioned, although I think it would be classified as a client provider in the OF world. the only thing to note is that Flipt added OFREP support in Flipt v1.47.0, so these endpoints wont exist in any versions of Flipt before this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please registry this provider in the release please manifest and config? Once that's in place, we should be good to release. Thanks!
@beeme1mr Yes! Just pushed the manifest & config updates |
Signed-off-by: atmask <[email protected]>
6d9e687
to
1bc44e2
Compare
@beeme1mr What blockers remain for getting this merged and releasing? Is release to pypi automated atm? |
Sorry, the blocker is me. I'll take care of this ASAP. |
Overview
This PR implements the Flipt provider by wrapping around the OFREP Provider and leveraging Flipt's OFREP api
Discussion Points:
Related Issues
Fixes #89
How to test
Unit Tests: From the base of the package run
hatch test
Local Usage: Go to the base of the new packager (i.e.
provider/openfeature-provider-flipt
), runpip install -e .
, and then open a python repl withpython3
: