Skip to content

MSSQL to handle duplicated columns names like other DB clients #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

Sylvestre67
Copy link

Resolves https://github.com/orgs/observablehq/projects/66/views/11.

Desciprition

The tedious/mssql client is exposing the following API to handle duplicated columns: https://github.com/orgs/observablehq/projects/66/views/11.

Refactored, the query stream to use the arrayRowMode and deduplicate the columns values for each row in a new Transform step before the JSONStream.stringify step.

@Sylvestre67 Sylvestre67 marked this pull request as ready for review November 9, 2022 21:47
@Sylvestre67 Sylvestre67 requested a review from visnup November 9, 2022 21:47
@Sylvestre67 Sylvestre67 merged commit 4f85a32 into main Nov 9, 2022
@Sylvestre67 Sylvestre67 deleted the syl/dedup-columns branch November 9, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants