Skip to content

fix: Do not use digests for Cilium images #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

jimmidyson
Copy link
Member

This would break for air-gapped installations as the repo digest
changes when we build the air-gapped bundle.

Depends on #900.
Depends on #899.

Base automatically changed from jimmi/calico-images to faiq/get-images September 9, 2024 12:45
An error occurred while trying to automatically change base from jimmi/calico-images to faiq/get-images September 9, 2024 12:45
Copy link
Contributor

github-actions bot commented Sep 9, 2024

@github-actions github-actions bot added the fix label Sep 9, 2024
Base automatically changed from faiq/get-images to main September 9, 2024 13:20
@github-actions github-actions bot added fix and removed fix labels Sep 9, 2024
This would break for air-gapped installations as the repo digest
changes when we build the air-gapped bundle,
Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, changed from:

"quay.io/cilium/cilium-envoy:v1.29.7-39a2a56bbd5b3a591f69dbca51d3e30ef97e0e51@sha256:bd5ff8c66716080028f414ec1cb4f7dc66f40d2fb5a009fff187f4a9b90b566b"
"quay.io/cilium/cilium-envoy:v1.29.7-39a2a56bbd5b3a591f69dbca51d3e30ef97e0e51"

@jimmidyson jimmidyson enabled auto-merge (squash) September 9, 2024 15:31
@jimmidyson jimmidyson merged commit 10ea179 into main Sep 12, 2024
19 checks passed
@jimmidyson jimmidyson deleted the jimmi/cilium-images branch September 12, 2024 14:44
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
dlipovetsky pushed a commit that referenced this pull request Sep 25, 2024
🤖 I have created a release *beep* *boop*
---


## 0.16.0 (2024-09-25)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Build with go 1.23 by @jimmidyson in
#889
* feat: Enable Hubble Relay in Cilium deployment via CAAPH by
@dlipovetsky in
#899
* feat: Extract CAAPH values templates to files by @jimmidyson in
#896
* feat: Build with go 1.23.1 by @jimmidyson in
#913
* feat: Support node taints per nodepool and control plane by
@jimmidyson in
#909
### Fixes 🔧
* fix: Remove deprecated toleration for node-role.kubernetes.io/master
by @jimmidyson in
#895
* fix: Do not use digests for Cilium images by @jimmidyson in
#901
### Other Changes
* test: Bump Kubernetes versions for tests by @jimmidyson in
#893
* ci: images tool by @faiq in
#822
* build: Include Calico images in image list by @jimmidyson in
#903
* build: Use upstream packages again from upstream by @jimmidyson in
#908
* ci(main): enable creating release-please PR from release branches by
@supershal in
#912
* docs: Enable dark mode, add Nutanix color, and header links by
@jimmidyson in
#915


**Full Changelog**:
v0.15.0...v0.16.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants