build: Ensure clean go build environment for goreleaser and ko #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous builds were overriding the
GOOS
andGOARCH
enviromentvariables, which is fine to do when using
ko
directly, but appears to bebroken when building via ko using
goreleaser
.This commit ensures that
GOOS
andGOARCH
are always unset whenrunning builds by undefining them via
make
undefine
. Theoverride
keyword ensures that the env vars are always undefined regardless of the
source (e.g. enviroment, make variables, etc) to ensure a clean build
environment.
Instead of using
GOARCH
env var for building for the local buildarchitecure, this commit uses
goreleaser
's{{ .Runtime.Goarch }}
variable available via templating which contains the architecture of the
build machine.
This commit also removes the
ldflags
config from theko
configuration in
goreleaser
config as this is automatically inheritedfrom the
build
config referenced in theko
config.