Skip to content

fix: Copy ClusterClasses and Templates without their owner references #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: Copy ClusterClasses and Templates without their owner references #776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 34 additions & 6 deletions pkg/controllers/namespacesync/copy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"fmt"

corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
"sigs.k8s.io/controller-runtime/pkg/client"
)
Expand All @@ -19,9 +20,7 @@ func copyClusterClassAndTemplates(
source *clusterv1.ClusterClass,
namespace string,
) error {
target := source.DeepCopy()
target.SetNamespace(namespace)
target.SetResourceVersion("")
target := copyObjectForCreate(source, source.Name, namespace)

if err := walkReferences(ctx, target, func(ctx context.Context, ref *corev1.ObjectReference) error {
// Get referenced Template
Expand All @@ -31,9 +30,7 @@ func copyClusterClassAndTemplates(
}

// Copy Template to target namespace
targetTemplate := sourceTemplate.DeepCopy()
targetTemplate.SetNamespace(namespace)
targetTemplate.SetResourceVersion("")
targetTemplate := copyObjectForCreate(sourceTemplate, sourceTemplate.GetName(), namespace)

if err := w.Create(ctx, targetTemplate); err != nil {
return fmt.Errorf(
Expand Down Expand Up @@ -63,3 +60,34 @@ func copyClusterClassAndTemplates(
}
return nil
}

// copyObjectForCreate copies the object, updating the name and namespace,
// and preserving only labels and annotations metadata.
func copyObjectForCreate[T client.Object](src T, name, namespace string) T {
dst := src.DeepCopyObject().(T)

dst.SetName(name)
dst.SetNamespace(namespace)

// Zero out ManagedFields (clients will set them)
dst.SetManagedFields(nil)
// Zero out OwnerReferences (object is garbage-collected if
// owners are not in the target namespace)
dst.SetOwnerReferences(nil)

// Zero out fields that are ignored by the API server on create
dst.SetCreationTimestamp(metav1.Time{})
dst.SetDeletionGracePeriodSeconds(nil)
dst.SetDeletionTimestamp(nil)
dst.SetFinalizers(nil)
dst.SetGenerateName("")
dst.SetGeneration(0)
dst.SetLabels(nil)
dst.SetManagedFields(nil)
dst.SetOwnerReferences(nil)
dst.SetResourceVersion("")
dst.SetSelfLink("")
dst.SetUID("")

return dst
}
Loading