fix: Add strategy to Nutanix CCM addon in examples #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
requested review from
dlipovetsky,
dkoshkin,
faiq,
thunderboltsid and
supershal
jimmidyson
force-pushed
the
jimmi/nutainx-ccm-strategy
branch
from
a4012c1 to
f96490d
Compare
Missed in previous PR when this ws refactored for AWS CCM. This was not found in the PR checks because we still do not have CI running on Nutanix infrastructure - but that is coming soon!
jimmidyson
force-pushed
the
jimmi/nutainx-ccm-strategy
branch
from
f96490d to
2946a8c
Compare
dkoshkin
approved these changes
Jun 29, 2024
mhrabovcin
approved these changes
Jul 1, 2024
Merged
jimmidyson
added a commit
that referenced
this pull request
Jul 1, 2024
🤖 I have created a release *beep* *boop* --- ## 0.11.2 (2024-07-01) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: Add strategy to Nutanix CCM addon in examples by @jimmidyson in #765 **Full Changelog**: v0.11.1...v0.11.2 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed in previous PR when this ws refactored for AWS CCM. This
was not found in the PR checks because we still do not have CI
running on Nutanix infrastructure - but that is coming soon!
I have tested this manually by running e2e against sherlock dev.