Skip to content

refactor: Fix up linter errors #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jimmidyson
Copy link
Member

Unnecessary conversions and using slices.Clone instead of looping with array
indices.

Unnecessary conversions and using `slices.Clone` instead of looping with array
indices.
@jimmidyson jimmidyson enabled auto-merge (squash) June 10, 2024 13:44
Copy link
Contributor

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I missed it as part of #698.

Just curious how did you spot this, did you IDE help you with that, or some linter?

@jimmidyson
Copy link
Member Author

@dkoshkin

how did you spot this, did you IDE help you with that, or some linter?

via pre-commit locally, you can either set up pre-commit hooks or run make pre-commit and see this. I'm not sure why this didn't break when you submitted the PR 🤔

Interestingly this did fail but wasn't reported properly - https://github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/actions/runs/9356466127/job/25754033310#step:5:9645

@jimmidyson jimmidyson disabled auto-merge June 10, 2024 16:51
@jimmidyson
Copy link
Member Author

Done in #707

@jimmidyson jimmidyson closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants