Skip to content

build: Temporary lint config fix until next golangci-lint release #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

build: Temporary lint config fix until next golangci-lint release #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,10 @@ issues:
- source: "// \\+kubebuilder:"
linters:
- lll
# Idiomatic to use init functions to register APIs with scheme
# Path is relative to api module root.
- path: "v1alpha1"
linters:
- gochecknoinits
# Temporary workaround until https://github.com/golangci/golangci-lint/pull/4698 is
# available in released version of golangci-lint
- path: "(test/e2e/e2e_suite_test.go|v1alpha1)"
text: "don't use `init` function"
# Idiomatic to use pass holderRef by value
- text: "hugeParam: holderRef is heavy"
linters:
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/e2e_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import (
clusterctltemp "github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix/test/framework/clusterctl"
)

func init() { //nolint:gochecknoinits // Idiomatically used to set up flags.
func init() {
flag.StringVar(&configPath, "e2e.config", "", "path to the e2e config file")
flag.StringVar(
&artifactFolder,
Expand Down
Loading