test: fix race condition between registry credentials and mirror tests #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supershal
force-pushed
the
shalin/containerd-mirror-unit-tets
branch
from
f546b8b to
1293e11
Compare
dkoshkin
approved these changes
Jan 19, 2024
| return NewKubeadmConfigTemplateRequest(uid, kubeadmConfigTemplateRequestObjectName) | ||
| } | ||
|
|
||
| func NewKubeadmConfigTemplateRequest( |
There was a problem hiding this comment.
How about something like this? I don't think dropping the "Item" is clear what the difference is
Suggested change
| func NewKubeadmConfigTemplateRequest( | |
| func NewNamedKubeadmConfigTemplateRequestItem( |
| @@ -75,8 +84,9 @@ func NewKubeadmConfigTemplateRequestItem(uid types.UID) runtimehooksv1.GenerateP | |||
| ) | |||
| } | |||
|
|
|||
| func NewKubeadmControlPlaneTemplateRequestItem( | |||
| func NewKubeadmControlPlaneTemplateRequest( | |||
| @@ -5,6 +5,7 @@ package tests | |||
|
|
|||
There was a problem hiding this comment.
Maybe we should rename this file to generate_credentials_patches.go to match the new generate_mirror_patches.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #292
Fixes flakes in unit tests for image registries: https://github.com/d2iq-labs/capi-runtime-extensions/actions/runs/7564146208/job/20597802432#step:5:68
When a static credentials are provided for registry, the patch generator creates secret that contains static credentials provider configuration with
registry-configsuffix. This fix is created with server side apply. however Server side apply does not work with the fake client, hack around it by pre-creating empty Secrets. kubernetes-sigs/controller-runtime#2341When we added more test cases for mirror registry, two parallel running tests were changing the same secrets that resulted in above error intermittently.
Fix: