Skip to content

fix: use repository more consistently #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2023
Merged

fix: use repository more consistently #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
514ce30
docs: fix to consistently use repository
dkoshkin Sep 19, 2023
fc596e2
fix: rename function to newImageRepositoryPatchHandler
dkoshkin Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/content/etcd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
title: "etcd"
---

Override the container image registry and tag for [etcd](https://github.com/etcd-io/etcd).
Override the container image repository and tag for [etcd](https://github.com/etcd-io/etcd).

To enable this handler set the `etcdpatch` and `etcdvars` external patches on `ClusterClass`.

Expand All @@ -19,7 +19,7 @@ spec:
discoverVariablesExtension: "etcdvars.capi-runtime-extensions"
```

On the cluster resource then specify desired etcd image registry and/or image tag values:
On the cluster resource then specify desired etcd image repository and/or image tag values:

```yaml
apiVersion: cluster.x-k8s.io/v1beta1
Expand Down
4 changes: 2 additions & 2 deletions docs/content/kubernetes-image-repository.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
title: "Kubernete Image Repository"
---

Override the container image registry used when pulling Kubernetes images.
Override the container image repository used when pulling Kubernetes images.

To enable this handler set the `imagerepositorypatch` and `imagerepositoryvars` external patches on `ClusterClass`.

Expand All @@ -19,7 +19,7 @@ spec:
discoverVariablesExtension: "imagerepositoryvars.capi-runtime-extensions"
```

On the cluster resource then specify desired Kubernetes image registry value:
On the cluster resource then specify desired Kubernetes image repository value:

```yaml
apiVersion: cluster.x-k8s.io/v1beta1
Expand Down
6 changes: 3 additions & 3 deletions pkg/handlers/kubernetesimagerepository/inject.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ var (
)

func NewPatch() *imageRepositoryPatchHandler {
return newImageRegistryPatchHandler(variableName)
return newImageRepositoryPatchHandler(variableName)
}

func NewMetaPatch() *imageRepositoryPatchHandler {
return newImageRegistryPatchHandler(handlers.MetaVariableName, variableName)
return newImageRepositoryPatchHandler(handlers.MetaVariableName, variableName)
}

func newImageRegistryPatchHandler(
func newImageRepositoryPatchHandler(
variableName string,
variableFieldPath ...string,
) *imageRepositoryPatchHandler {
Expand Down