-
Notifications
You must be signed in to change notification settings - Fork 7
feat: Add ClusterConfig variable and patch handler #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
21311ed
feat: Add ClusterConfig variable and patch handler
jimmidyson e7ac3b5
fixup! revert: Revert http-proxy docs
jimmidyson 5a77256
fixup! fix: Propagate wrapped handler response
jimmidyson 60c2c4f
test: Add unit test for meta generate patches handler
jimmidyson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,3 +36,5 @@ public/ | |
resources/ | ||
node_modules/ | ||
.hugo_build.lock | ||
|
||
/cluster.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,111 @@ | ||
// Copyright 2023 D2iQ, Inc. All rights reserved. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package v1alpha1 | ||
|
||
import ( | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1" | ||
|
||
"github.com/d2iq-labs/capi-runtime-extensions/common/pkg/openapi/patterns" | ||
) | ||
|
||
//+kubebuilder:object:root=true | ||
|
||
// ClusterConfig is the Schema for the clusterconfigs API. | ||
type ClusterConfig struct { | ||
metav1.TypeMeta `json:",inline"` | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
||
Spec ClusterConfigSpec `json:"spec,omitempty"` | ||
} | ||
|
||
// ClusterConfigSpec defines the desired state of ClusterConfig. | ||
type ClusterConfigSpec struct { | ||
// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster | ||
// Important: Run "make" to regenerate code after modifying this file | ||
|
||
// +optional | ||
Proxy *HTTPProxy `json:"proxy,omitempty"` | ||
|
||
// +optional | ||
ExtraAPIServerCertSANs ExtraAPIServerCertSANs `json:"extraAPIServerCertSANs,omitempty"` | ||
} | ||
|
||
func (ClusterConfigSpec) VariableSchema() clusterv1.VariableSchema { | ||
return clusterv1.VariableSchema{ | ||
OpenAPIV3Schema: clusterv1.JSONSchemaProps{ | ||
Description: "Cluster configuration", | ||
Type: "object", | ||
Properties: map[string]clusterv1.JSONSchemaProps{ | ||
"proxy": HTTPProxy{}.VariableSchema().OpenAPIV3Schema, | ||
"extraAPIServerCertSANs": ExtraAPIServerCertSANs{}.VariableSchema().OpenAPIV3Schema, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
// HTTPProxy required for providing proxy configuration. | ||
type HTTPProxy struct { | ||
// HTTP proxy. | ||
HTTP string `json:"http,omitempty"` | ||
|
||
// HTTPS proxy. | ||
HTTPS string `json:"https,omitempty"` | ||
|
||
// AdditionalNo Proxy list that will be added to the automatically calculated | ||
// values that will apply no_proxy configuration for cluster internal network. | ||
// Default values: localhost,127.0.0.1,<POD_NETWORK>,<SERVICE_NETWORK>,kubernetes | ||
// ,kubernetes.default,.svc,.svc.<SERVICE_DOMAIN> | ||
AdditionalNo []string `json:"additionalNo"` | ||
} | ||
|
||
func (HTTPProxy) VariableSchema() clusterv1.VariableSchema { | ||
return clusterv1.VariableSchema{ | ||
OpenAPIV3Schema: clusterv1.JSONSchemaProps{ | ||
Type: "object", | ||
Properties: map[string]clusterv1.JSONSchemaProps{ | ||
"http": { | ||
Description: "HTTP proxy value.", | ||
Type: "string", | ||
}, | ||
"https": { | ||
Description: "HTTPS proxy value.", | ||
Type: "string", | ||
}, | ||
"additionalNo": { | ||
Description: "Additional No Proxy list that will be added to the automatically calculated " + | ||
"values required for cluster internal network. " + | ||
"Default value: localhost,127.0.0.1,<POD_NETWORK>,<SERVICE_NETWORK>,kubernetes," + | ||
"kubernetes.default,.svc,.svc.<SERVICE_DOMAIN>", | ||
Type: "array", | ||
Items: &clusterv1.JSONSchemaProps{ | ||
Type: "string", | ||
}, | ||
}, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
// ExtraAPIServerCertSANs required for providing API server cert SANs. | ||
type ExtraAPIServerCertSANs []string | ||
|
||
func (ExtraAPIServerCertSANs) VariableSchema() clusterv1.VariableSchema { | ||
return clusterv1.VariableSchema{ | ||
OpenAPIV3Schema: clusterv1.JSONSchemaProps{ | ||
Description: "Extra Subject Alternative Names for the API Server signing cert", | ||
Type: "array", | ||
UniqueItems: true, | ||
Items: &clusterv1.JSONSchemaProps{ | ||
Type: "string", | ||
Pattern: patterns.Anchored(patterns.DNS1123Subdomain), | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
// +kubebuilder:object:root=true | ||
func init() { | ||
SchemeBuilder.Register(&ClusterConfig{}) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// Copyright 2023 D2iQ, Inc. All rights reserved. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
// Package v1alpha1 contains API Schema definitions for the CAPI extensions v1alpha1 API group | ||
// +kubebuilder:object:generate=true | ||
// +groupName=capiext.labs.d2iq.io | ||
// | ||
//go:generate -command CTRLGEN controller-gen paths="./..." | ||
//go:generate CTRLGEN rbac:headerFile="../../hack/license-header.yaml.txt",roleName=capi-runtime-extensions-manager-role output:rbac:artifacts:config=../../charts/capi-runtime-extensions/templates | ||
//go:generate CTRLGEN object:headerFile="../../hack/license-header.go.txt" output:object:artifacts:config=/dev/null | ||
package v1alpha1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
// Copyright 2023 D2iQ, Inc. All rights reserved. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
package mutation | ||
|
||
import ( | ||
"context" | ||
"strings" | ||
|
||
runtimehooksv1 "sigs.k8s.io/cluster-api/exp/runtime/hooks/api/v1alpha1" | ||
|
||
"github.com/d2iq-labs/capi-runtime-extensions/common/pkg/capi/clustertopology/handlers" | ||
) | ||
|
||
type metaGeneratePatches struct { | ||
name string | ||
wrappedHandlers []GeneratePatches | ||
} | ||
|
||
func NewMetaGeneratePatchesHandler(name string, gp ...GeneratePatches) handlers.Named { | ||
return metaGeneratePatches{ | ||
name: name, | ||
wrappedHandlers: gp, | ||
} | ||
} | ||
|
||
func (mgp metaGeneratePatches) Name() string { | ||
return mgp.name | ||
} | ||
|
||
func (mgp metaGeneratePatches) GeneratePatches( | ||
ctx context.Context, | ||
req *runtimehooksv1.GeneratePatchesRequest, | ||
resp *runtimehooksv1.GeneratePatchesResponse, | ||
) { | ||
for _, h := range mgp.wrappedHandlers { | ||
wrappedResp := &runtimehooksv1.GeneratePatchesResponse{} | ||
h.GeneratePatches(ctx, req, wrappedResp) | ||
resp.Items = append(resp.Items, wrappedResp.Items...) | ||
if wrappedResp.Message != "" { | ||
resp.Message = strings.TrimPrefix(resp.Message+"\n"+wrappedResp.Message, "\n") | ||
} | ||
if wrappedResp.Status != runtimehooksv1.ResponseStatusSuccess { | ||
wrappedResp.Status = runtimehooksv1.ResponseStatusSuccess | ||
return | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.