feat: Fix up Kubelet file permissions #1110
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
requested review from
dkoshkin,
thunderboltsid,
supershal,
yannickstruyf3 and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR aims to address CIS benchmark requirements by disabling profiling for control plane components and enforcing secure file permissions for Kubelet.
- Disabled profiling for apiServer, controllerManager, and scheduler in various cluster class templates
- Added postKubeadmCommands to set file permissions on Kubelet config and service files
- Introduced an example patch and updated configuration files across Nutanix, Docker, and AWS cluster classes
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hack/examples/patches/disable-kubeadmcontrolplane-profiling.yaml | Adds a patch to disable profiling on control plane components |
| charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/nutanix-cluster-class.yaml | Updates cluster class with profiling disabled and adds chmod commands for Kubelet files |
| charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/nutanix-cluster-class-old.yaml | Introduces an old cluster class configuration for backward compatibility |
| charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/docker-cluster-class.yaml | Updates Docker cluster class with disabled profiling and Kubelet permissions changes |
| charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/aws-cluster-class.yaml | Updates AWS cluster class by disabling profiling and enforcing Kubelet file permissions |
Files not reviewed (3)
- hack/examples/overlays/clusterclasses/aws/kustomization.yaml.tmpl: Language not supported
- hack/examples/overlays/clusterclasses/docker/kustomization.yaml.tmpl: Language not supported
- hack/examples/overlays/clusterclasses/nutanix/kustomization.yaml.tmpl: Language not supported
jimmidyson
changed the title
dkoshkin
reviewed
Apr 24, 2025
charts/cluster-api-runtime-extensions-nutanix/defaultclusterclasses/aws-cluster-class.yaml
Outdated
Show resolved
Hide resolved
jimmidyson
force-pushed
the
jimmi/cis-brnchmarks-kubeletservice-permissions
branch
3 times, most recently
from
aaa27e9 to
5713c6e
Compare
As per CIS benchmarks 4.1.1 and 4.1.9.
jimmidyson
force-pushed
the
jimmi/cis-brnchmarks-kubeletservice-permissions
branch
from
5713c6e to
ffc5425
Compare
thunderboltsid
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per CIS benchmarks 4.1.1 and 4.1.9.
Requires #1109