fix: use a new version for control-plane and worker mutation handlers #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/fix-cp-worker-handlers-versions
branch
2 times, most recently
from
90f9f0b to
5233ba6
Compare
Previously, the addition of the noderegistration handler and API defaults caused a rollout of all Machines when CAREN was upgraded.
dkoshkin
force-pushed
the
dkoshkin/fix-cp-worker-handlers-versions
branch
from
5233ba6 to
db1feae
Compare
faiq
reviewed
Apr 14, 2025
faiq
approved these changes
Apr 14, 2025
Merged
dkoshkin
added a commit
that referenced
this pull request
Apr 14, 2025
🤖 I have created a release *beep* *boop* --- ## 0.28.1 (2025-04-14) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: use a new version for control-plane and worker mutation handlers by @dkoshkin in #1104 ### Other Changes * build: use correct frr image for metallb by @dkoshkin in #1102 **Full Changelog**: v0.28.0...v0.28.1 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
When adding #1097, we effectively enabled this handler by default through API defaults. I wrongly assumed that the worker and control-plane handlers were behind a new version of the handlers registration. And because its not, this caused a rollout of all Machines when CAREN is upgraded on the management cluster.
This PR puts the worker and control-plane handlers behind a new version of the hooks and does not include the new
noderegistrationhandler in the older version of the hooks.Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Tested locally by upgrading the handler version and observing that Machines were NOT rolled out. We will need some strategy to test this in an e2e test, or possibly think of a different approach for this, e.g. running multiple versions of the controller instead of embedding it in a single handler.
Special notes for your reviewer: