-
Notifications
You must be signed in to change notification settings - Fork 7
feat: COSI controller Addon #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
488e7f6
to
06f097f
Compare
dkoshkin
commented
Jan 7, 2025
06f097f
to
5276e17
Compare
thunderboltsid
approved these changes
Jan 9, 2025
faiq
reviewed
Jan 13, 2025
jimmidyson
reviewed
Jan 14, 2025
faiq
approved these changes
Jan 14, 2025
Merged
dkoshkin
added a commit
that referenced
this pull request
Jan 16, 2025
🤖 I have created a release *beep* *boop* --- ## 0.25.0 (2025-01-16) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Virtual IP configuration to set different address/port by @dkoshkin in #986 * feat: update addon versions by @dkoshkin in #997 * feat: COSI controller Addon by @dkoshkin in #1008 ### Fixes 🔧 * fix: check HelmReleaseReadyCondition when status is up-to-date by @dkoshkin in #989 * fix: update CoreDNS mapping file by @dkoshkin in #998 * fix: validates PC IP is outside Load Balancer IP Range by @manoj-nutanix in #1001 * fix: update COSI controller image to fix CVEs by @dkoshkin in #1012 * fix(deps): Update Nutanix CCM Version by @thunderboltsid in #1016 * fix: update AWS CCM to latest versions by @dkoshkin in #1013 ### Other Changes * refactor: new waiter functionality in helmAddonApplier by @dkoshkin in #988 * build: Properly ignore ntnx API client from dependabot by @jimmidyson in #995 **Full Changelog**: v0.24.0...v0.25.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jimmidyson
pushed a commit
that referenced
this pull request
Jan 20, 2025
**What problem does this PR solve?**: Missed this in #1008 since I thought that all HCP are already checked. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
This PR adds the COSI controller Addon, without any providers.
The chart comes from https://github.com/mesosphere/charts/tree/master/stable/cosi
The addon does not take in any configuration so the API to enable it is just:
Once we add providers, the API can be similar to what it is with CSI with a
providers:
field.Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
New unit tests.
Also deployed it on a Nutanix Cluster and the Nutanix COSI driver from nutanix-cloud-native/cosi-driver-nutanix#375
Create the credentials Secret
The Secret was correctly generated and the test Pod wrote and read to a new bucket.
Special notes for your reviewer: