Skip to content

Patch: AWS LoadBalancer scheme #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkoshkin opened this issue Oct 2, 2023 · 0 comments · Fixed by #228
Closed

Patch: AWS LoadBalancer scheme #202

dkoshkin opened this issue Oct 2, 2023 · 0 comments · Fixed by #228
Assignees
@dkoshkin

Comments

@dkoshkin
Copy link
Contributor

dkoshkin commented Oct 2, 2023 •
edited
Loading

Add a patch to set the scheme to use for the control-plane Server LoadBalancer - https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/1fb82d9f556c0d840bafa519f63407cac8de2b9b/api/v1beta2/awscluster_types.go#L183

Here is a proposed API:

values:
  aws:
    controlPlaneLoadBalancer:
      scheme: *ClassicELBScheme (from CAPA API package)

Needed to support creating clusters in existing air-gapped infrastructure.
@dkoshkin dkoshkin mentioned this issue Oct 16, 2023
Merged
@dkoshkin dkoshkin self-assigned this Oct 16, 2023
dkoshkin added a commit that referenced this issue Nov 9, 2023
@dkoshkin
feat: add control-plane load balancer scheme patch (#228)
72780f6 
Fixes #202

Depends on #220

Tested manually setting the `internal`
```
  spec:
    bastion:
      allowedCIDRBlocks:
      - 0.0.0.0/0
      enabled: false
    controlPlaneEndpoint:
      host: ""
      port: 0
    controlPlaneLoadBalancer:
      crossZoneLoadBalancing: false
      loadBalancerType: classic
      scheme: internal
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkoshkin dkoshkin

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dkoshkin