Skip to content

Patch: AWS Subnet IDs #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkoshkin opened this issue Oct 2, 2023 · 0 comments · Fixed by #220
Closed

Patch: AWS Subnet IDs #200

dkoshkin opened this issue Oct 2, 2023 · 0 comments · Fixed by #220
Assignees
@dkoshkin

Comments

@dkoshkin
Copy link
Contributor

dkoshkin commented Oct 2, 2023

Add a patch to set existing Subnets to use https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/1fb82d9f556c0d840bafa519f63407cac8de2b9b/api/v1beta1/network_types.go#L154-L156

Here is a proposed API:

values:
  aws:
    network:
      subnets:
      - id:
      ...

Needed to support creating clusters in existing air-gapped infrastructure.
@dkoshkin dkoshkin self-assigned this Oct 9, 2023
@dkoshkin dkoshkin mentioned this issue Oct 10, 2023
Merged
dkoshkin added a commit that referenced this issue Oct 17, 2023
@dkoshkin
feat: add VPC ID and Subnet IDs patch (#220)
349bf97 
Fixes #201
Fixes #200

Depends on #219

Tested manually (at-least that the values are set in `AWSCluster`)
```
apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
  name: <NAME>
spec:
  topology:
    variables:
      - name: clusterConfig
        value:
          aws:
            network:
              vpc:
                id: vpc-1234567890
              subnets:
                - id: subnet-1
                - id: subnet-2
                - id: subnet-3
```

This is what the `AWSCluster` looked like:
```
  spec:
    network:
      subnets:
      - id: subnet-1
        isPublic: false
      - id: subnet-2
        isPublic: false
      - id: subnet-3
        isPublic: false
      vpc:
        availabilityZoneSelection: Ordered
        availabilityZoneUsageLimit: 3
        id: vpc-1234567890
    region: us-west-2
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkoshkin dkoshkin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add VPC ID and Subnet IDs patch nutanix-cloud-native/cluster-api-runtime-extensions-nutanix
1 participant
@dkoshkin