Revert "Remove dockerhub registry patch"

This reverts commit 9c515b7.

Author: thunderboltsid

.github/workflows/e2e.yml

@@ -78,6 +78,8 @@ jobs:
         run: devbox run -- make e2e-test E2E_LABEL='provider:${{ inputs.provider }} && cni:Cilium && addonStrategy:HelmAddon' E2E_SKIP='${{ inputs.skip }}' E2E_FOCUS='${{ inputs.focus }}'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          DOCKER_HUB_USERNAME: ${{ secrets.DOCKER_HUB_USERNAME }}
+          DOCKER_HUB_PASSWORD: ${{ secrets.DOCKER_HUB_PASSWORD }}
           NUTANIX_ENDPOINT: ${{ secrets.NUTANIX_ENDPOINT }}
           NUTANIX_USER: ${{ secrets.NUTANIX_USER }}
           NUTANIX_PASSWORD: ${{ secrets.NUTANIX_PASSWORD }}

examples/capi-quick-start/nutanix-cluster-calico-crs.yaml

@@ -111,6 +111,11 @@ spec:
         encryptionAtRest:
           providers:
           - aescbc: {}
+        imageRegistries:
+        - credentials:
+            secretRef:
+              name: ${CLUSTER_NAME}-dockerhub-credentials
+          url: https://docker.io
         nutanix:
           controlPlaneEndpoint:
             host: ${CONTROL_PLANE_ENDPOINT_IP}

examples/capi-quick-start/nutanix-cluster-calico-helm-addon.yaml

@@ -111,6 +111,11 @@ spec:
         encryptionAtRest:
           providers:
           - aescbc: {}
+        imageRegistries:
+        - credentials:
+            secretRef:
+              name: ${CLUSTER_NAME}-dockerhub-credentials
+          url: https://docker.io
         nutanix:
           controlPlaneEndpoint:
             host: ${CONTROL_PLANE_ENDPOINT_IP}

examples/capi-quick-start/nutanix-cluster-cilium-crs.yaml

@@ -111,6 +111,11 @@ spec:
         encryptionAtRest:
           providers:
           - aescbc: {}
+        imageRegistries:
+        - credentials:
+            secretRef:
+              name: ${CLUSTER_NAME}-dockerhub-credentials
+          url: https://docker.io
         nutanix:
           controlPlaneEndpoint:
             host: ${CONTROL_PLANE_ENDPOINT_IP}

examples/capi-quick-start/nutanix-cluster-cilium-helm-addon.yaml

@@ -111,6 +111,11 @@ spec:
         encryptionAtRest:
           providers:
           - aescbc: {}
+        imageRegistries:
+        - credentials:
+            secretRef:
+              name: ${CLUSTER_NAME}-dockerhub-credentials
+          url: https://docker.io
         nutanix:
           controlPlaneEndpoint:
             host: ${CONTROL_PLANE_ENDPOINT_IP}

hack/examples/bases/nutanix/cluster/kustomization.yaml.tmpl

@@ -66,6 +66,9 @@ patches:
 # A Nutanix cluster uses SNAT for outbound traffic by default.
 # Because Dockerhub only sees a single request IP the rate limit gets hit for almost every cluster.
 # Add a patch to set imageRegistry with docker.io credentials.
+- target:
+    kind: Cluster
+  path: ../../../patches/dockerhub-image-registry.yaml
 
 # Change the machineDeployments Class to match the other examples.
 - target: