Revert "Remove dockerhub credential secret"

This reverts commit 27f84fd.

Author: thunderboltsid

examples/capi-quick-start/nutanix-cluster-calico-crs.yaml

@@ -1,5 +1,16 @@
 apiVersion: v1
 kind: Secret
+metadata:
+  labels:
+    cluster.x-k8s.io/provider: nutanix
+  name: ${CLUSTER_NAME}-dockerhub-credentials
+stringData:
+  password: ${DOCKER_HUB_PASSWORD}
+  username: ${DOCKER_HUB_USERNAME}
+type: Opaque
+---
+apiVersion: v1
+kind: Secret
 metadata:
   labels:
     cluster.x-k8s.io/provider: nutanix

examples/capi-quick-start/nutanix-cluster-calico-helm-addon.yaml

@@ -1,5 +1,16 @@
 apiVersion: v1
 kind: Secret
+metadata:
+  labels:
+    cluster.x-k8s.io/provider: nutanix
+  name: ${CLUSTER_NAME}-dockerhub-credentials
+stringData:
+  password: ${DOCKER_HUB_PASSWORD}
+  username: ${DOCKER_HUB_USERNAME}
+type: Opaque
+---
+apiVersion: v1
+kind: Secret
 metadata:
   labels:
     cluster.x-k8s.io/provider: nutanix

examples/capi-quick-start/nutanix-cluster-cilium-crs.yaml

@@ -1,5 +1,16 @@
 apiVersion: v1
 kind: Secret
+metadata:
+  labels:
+    cluster.x-k8s.io/provider: nutanix
+  name: ${CLUSTER_NAME}-dockerhub-credentials
+stringData:
+  password: ${DOCKER_HUB_PASSWORD}
+  username: ${DOCKER_HUB_USERNAME}
+type: Opaque
+---
+apiVersion: v1
+kind: Secret
 metadata:
   labels:
     cluster.x-k8s.io/provider: nutanix

examples/capi-quick-start/nutanix-cluster-cilium-helm-addon.yaml

@@ -1,5 +1,16 @@
 apiVersion: v1
 kind: Secret
+metadata:
+  labels:
+    cluster.x-k8s.io/provider: nutanix
+  name: ${CLUSTER_NAME}-dockerhub-credentials
+stringData:
+  password: ${DOCKER_HUB_PASSWORD}
+  username: ${DOCKER_HUB_USERNAME}
+type: Opaque
+---
+apiVersion: v1
+kind: Secret
 metadata:
   labels:
     cluster.x-k8s.io/provider: nutanix

hack/examples/bases/nutanix/cluster/kustomization.yaml.tmpl

@@ -5,6 +5,7 @@ apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 
 resources:
+- ../../../additional-resources/dockerhub-secret.yaml
 - ../../../additional-resources/nutanix/csi-secret.yaml
 - https://github.com/nutanix-cloud-native/cluster-api-provider-nutanix/releases/download/${CAPX_VERSION}/cluster-template-topology.yaml
 

test/e2e/config/caren.yaml

@@ -188,15 +188,15 @@ variables:
   # IP/FQDN of Prism Central.
   # NOTE: This has to be overridden by specifying the env var NUTANIX_ENDPOINT when running the e2e tests. It is
   # set as empty here to enable running the e2e tests for non-nutanix providers locally without setting the env var.
-  #  NUTANIX_ENDPOINT: ""
+  NUTANIX_ENDPOINT: ""
   # # Port of Prism Central. Default: 9440
   # NUTANIX_PORT: 9440
   # # Disable Prism Central certificate checking. Default: false
   # NUTANIX_INSECURE: false
   # # Prism Central user
-  #  NUTANIX_USER: ""
+  NUTANIX_USER: ""
   # # Prism Central password
-  #  NUTANIX_PASSWORD: ""
+  NUTANIX_PASSWORD: ""
   # # Host IP to be assigned to the CAPX Kubernetes cluster.
   # CONTROL_PLANE_ENDPOINT_IP: ""
   # # Port of the CAPX Kubernetes cluster. Default: 6443
@@ -209,6 +209,9 @@ variables:
   # NUTANIX_SUBNET_NAME: ""
   # # Name of the storage container to CSI driver
   # NUTANIX_STORAGE_CONTAINER_NAME: ""
+  # # Username/Password of dockerhub account to avoid download rate limiting
+  # DOCKER_HUB_USERNAME: ""
+  # DOCKER_HUB_PASSWORD: ""
 
 intervals:
   default/wait-controllers: ["3m", "10s"]