refactor: Tidy up Nutanix CSI with consistent apply strategy

Move the current logic out to a helm addon strategy as done in other providers.

Also move Helm release to kube-system to be consistent with other CSI providers.

And tidy up flag names to use `--csi.nutanix.` prefix for flags, including wiring
up to Helm chart values and deployment.

Finally, add e2e test for CSI deployment in Nutanix infra.

Author: jimmidyson

charts/cluster-api-runtime-extensions-nutanix/templates/deployment.yaml

@@ -36,7 +36,6 @@ spec:
         - --csi.aws-ebs.helm-addon.default-values-template-configmap-name={{ (index .Values.hooks.csi "aws-ebs").helmAddonStrategy.defaultValueTemplateConfigMap.name }}
         - --csi.nutanix.helm-addon.default-values-template-configmap-name={{ (index .Values.hooks.csi "nutanix").helmAddonStrategy.defaultValueTemplateConfigMap.name }}
         - --csi.local-path.helm-addon.default-values-template-configmap-name={{ (index .Values.hooks.csi "local-path").helmAddonStrategy.defaultValueTemplateConfigMap.name }}
-        - --csi.aws-ebs.helm-addon.default-values-template-configmap-name={{ (index .Values.hooks.csi "aws-ebs").helmAddonStrategy.defaultValueTemplateConfigMap.name }}
         {{- range $key, $value := .Values.extraArgs }}
         - --{{ $key }}={{ $value }}
         {{- end }}

hack/addons/kustomize/nutanix-snapshot-csi/kustomization.yaml.tmpl

@@ -7,7 +7,7 @@ kind: Kustomization
 metadata:
   name: nutanix-csi-kustomize
 
-namespace: kube-system
+namespace: ntnx-system
 
 helmCharts:
 - name: nutanix-csi-snapshot
@@ -16,3 +16,4 @@ helmCharts:
   version: ${NUTANIX_SNAPSHOT_CSI_CHART_VERSION}
   includeCRDs: true
   skipTests: true
+  namespace: ntnx-system

hack/addons/kustomize/nutanix-storage-csi/kustomization.yaml.tmpl

@@ -7,7 +7,7 @@ kind: Kustomization
 metadata:
   name: nutanix-csi-kustomize
 
-namespace: kube-system
+namespace: ntnx-system
 
 helmCharts:
 - name: nutanix-csi-storage
@@ -16,3 +16,4 @@ helmCharts:
   version: ${NUTANIX_STORAGE_CSI_CHART_VERSION}
   includeCRDs: true
   skipTests: true
+  namespace: ntnx-system