Skip to content

Remove incorrect comment about checking generated C files in #22235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

williamstein
Copy link
Contributor

Evidently the decision was made at some point not to do what Dag suggests in the documentation of this file. So delete that suggestion, which conflicts with reality. I agree with not checking in the C files, and think Cython isn't an unreasonable dependency for building from git. Also, cython is clearly stated to be a build dependency here: https://github.com/numpy/numpy/blob/main/INSTALL.rst#id9

Evidently the decision was made at some point not to do what Dag suggests in the documentation of this file.  So delete that suggestion, which conflicts with reality.  I agree with not checking in the C files, and think Cython isn't an unreasonable dependency for building from git.  Also, cython is clearly stated to be a build dependency here: https://github.com/numpy/numpy/blob/main/INSTALL.rst#id9
@williamstein
Copy link
Contributor Author

This is only a change to a docstring, so should be very safe.

@mattip mattip merged commit 4a9b714 into numpy:main Sep 9, 2022
@mattip
Copy link
Member

mattip commented Sep 9, 2022

Thanks @williamstein

@InessaPawson
Copy link
Member

Hi-five on merging your first pull request to NumPy, @williamstein! We hope you stick around! Your choices aren’t limited to writing patches – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants