Skip to content

Add translations team #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add translations team #806

merged 2 commits into from
Dec 18, 2024

Conversation

melissawm
Copy link
Member

Brief description of what is fixed or changed

Hi all! This PR adds a "Translations team" section to the teams page. The toml file is manually added since translators are members of crowdin but not necessarily github.

I am happy to add links to github profiles and/or new avatars, just let me know. As a placeholder, folks without an avatar are showing up as the NumPy logo.

Closes #796

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 02373cd
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/676174e8c86acf0008f1de68
😎 Deploy Preview https://deploy-preview-806--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefanv
Copy link
Contributor

stefanv commented Dec 17, 2024

Hi @melissawm, is it possible to make the crowdin project public so we can automatically scrape team members? AFAI understand, you can make a project public without automatically allowing volunteers to join; but I don't know if we can see team members of a public project; worth looking, though?

@rgommers
Copy link
Member

I'm not sure about making the Crowdin project public - perhaps there is value in that in itself - however automatically scraping team members doesn't seem desirable. Translators get added immediately on request, but we only want to credit them as part of the NumPy Translations Team after a substantial set of contributions, just like there is a bar for being listed as part of other teams.

@rgommers
Copy link
Member

I am happy to add links to github profiles and/or new avatars, just let me know. As a placeholder, folks without an avatar are showing up as the NumPy logo.

The links should go to GitHub profiles (when available) in my opinion, and then the profile images will show up so this will start looking more normal:

image

@rgommers
Copy link
Member

Thanks for doing this Melissa, +1 for crediting translators!

@melissawm
Copy link
Member Author

@stefanv we can definitely investigate that, but depending on the effort involved in scraping maybe that could be a follow-up? I think having the translators credited helps with both engagement for new translators and actual rewards for the work done, so I would not like to let it sit for too long 😄

@stefanv
Copy link
Contributor

stefanv commented Dec 18, 2024

OK, I'll merge if you'll investigate that option 🤝 🙂

@stefanv stefanv merged commit 0b5bdfb into numpy:main Dec 18, 2024
4 checks passed
@stefanv
Copy link
Contributor

stefanv commented Dec 18, 2024

Sorry, I missed Ralf's comment:

but we only want to credit them as part of the NumPy Translations Team after a substantial set of contributions, just like there is a bar for being listed as part of other teams.

In that case, fine to keep this as-is.

@stefanv
Copy link
Contributor

stefanv commented Dec 18, 2024

(BTW profile currently links to the crowdin page, which most people can't see.)

@melissawm
Copy link
Member Author

@steppi do you know how to make the crowdin pages for the scientific python projects be public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "Translation Team" to the teams page
3 participants