Skip to content

Update translations for Spanish #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 172 commits into from
Sep 18, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

This PR to update translations for Spanish was generated by the GitHub workflow, auto-translations-pr.yml and includes all commits from this repo's Crowdin branch for the language of interest. A final check of the rendered docs is needed to identify if there are any formatting errors due to incorrect string segmentation by Crowdin. If there are such formatting errors, they should be fixed directly on this branch, not through Crowdin.

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for numpy-org failed.

Name Link
🔨 Latest commit f7380fb
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/66eb203788866400087a4eb0

* Enable Spanish translations

* Fix some shortcode text + formatting issues

* Figure shortcode formatting fixes

* Fix language name
@steppi
Copy link
Contributor

steppi commented Sep 17, 2024

The link checking netlify plugin is very useful.

steppi and others added 5 commits September 18, 2024 14:08
* New translations index.md (Spanish)

* New translations _index.md (Spanish)

* New translations gw-discov.md (Spanish)

* New translations index.md (Spanish)

* Fix some broken links

---------

Co-authored-by: Ralf Gommers <[email protected]>
@melissawm
Copy link
Member

melissawm commented Sep 18, 2024

It looks like the remaining failure is due to a redirect for the code-of-conduct page.

Details

3:09:16 PM: ✖ FAIL load https://numpy.org/es/code-of-conduct/
3:09:16 PM: | operator: load
3:09:16 PM: | expected: 200 https://numpy.org/es/code-of-conduct/
3:09:16 PM: | actual: HTTP 404 Not Found
3:09:16 PM: | at: public/conduct.html:4:12

AFAICT this is due to the fact that the redirect url does not exist yet because this PR hasn't been merged, so I think it's safe to ignore.

I'll also note for the future:

  • We manually added the terms.md document to the Spanish folder because even though this document should not be translated, we need to have a copy of it in every language (we should just make sure it is kept up-to-date, but I don't think we expect any changes to this document in the foreseeable future).
  • In the Report Handling Manual, there are a few automatically created anchors that should be translated, resulting in links that should also be translated in other parts of the content - which is different from almost all links which should not be translated. This will happen for all languages so it's something to be aware of.

@melissawm
Copy link
Member

I am merging this optimistically but will keep an eye out for the broken link in case that is still an issue. Thanks @steppi !

@melissawm melissawm merged commit 54c3861 into main Sep 18, 2024
0 of 4 checks passed
@melissawm melissawm deleted the l10n_main_es_2024_09_17_15_16_33 branch September 18, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants