Skip to content

Use grid of cards for team gallery #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

jarrodmillman
Copy link
Member

@steppi @rgommers For the outstanding translations, you need to turn the team page (e.g., content/pt/teams.md) into a bundle (e.g., content/pt/teams/index.md):

$ mkdir content/pt/teams
$ git mv content/pt/teams.md content/pt/teams/index.md

Once you commit that, you will have the following directory structure

$ tree content/pt/teams
content/pt/teams
└── index.md

Then in content/pt/teams/index.md change

{{< include-html "static/gallery/maintainers.html" >}}

{{< include-html "static/gallery/docs-team.html" >}}

{{< include-html "static/gallery/web-team.html" >}}

{{< include-html "static/gallery/triage-team.html" >}}

{{< include-html "static/gallery/survey-team.html" >}}

{{< include-html "static/gallery/emeritus-maintainers.html" >}}

to

### Maintainers

{{< grid1 file="maintainers.toml" columns="2 3 4 5" />}}

### Docs team

{{< grid1 file="docs-team.toml" columns="2 3 4 5" />}}

### Web team

{{< grid1 file="web-team.toml" columns="2 3 4 5" />}}

### Triage team

{{< grid1 file="triage-team.toml" columns="2 3 4 5" />}}

### Survey team

{{< grid1 file="survey-team.toml" columns="2 3 4 5" />}}

### Emeritus maintainers

{{< grid1 file="emeritus-maintainers.toml" columns="2 3 4 5" />}}

All the translations will share the same toml files (i.e., the one in content/en/teams):

$ tree content/en/teams
content/en/teams
├── docs-team.toml
├── emeritus-maintainers.toml
├── index.md
├── maintainers.toml
├── survey-team.toml
├── triage-team.toml
└── web-team.toml

FYI, this has nothing to do with the fact that it is the default language. Hugo first looks in each
translation's own bundle. If it doesn't find the resouce in the translation's own bundle, it will look
in another translation's bundle. If there are mutliple options, hugo will choose the translation
with greatest respective Weight.

Finally, as mentioned in #733, after the next release we will need to rename grid1 to grid.

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 9297cec
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/65f03882327e9c000812c4b5
😎 Deploy Preview https://deploy-preview-734--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rgommers
Copy link
Member

That sounds reasonable to me. I'll defer to @steppi here, since he knows better what the impact on translation machinery is.

@steppi
Copy link
Contributor

steppi commented Mar 12, 2024

That sounds reasonable to me. I'll defer to @steppi here, since he knows better what the impact on translation machinery is.

From my understanding, we can resync Crowdin by closing its pull request and letting it re-open another one, so I think it should be fine.

@jarrodmillman jarrodmillman merged commit f6680ba into numpy:main Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants