Skip to content

Change icon colors in Sience Domains tab of Ecosystem section #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 29, 2022

Conversation

ernestofgonzalez
Copy link
Contributor

Brief description of what is fixed or changed

Following is a screenshot of the result:

Screenshot 2022-10-28 at 00 17 43

@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit ae59aa6
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/635c66ecb8868a0008af0b6d
😎 Deploy Preview https://deploy-preview-607--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@stefanv
Copy link
Contributor

stefanv commented Oct 28, 2022

If we're updating the icon colors, should we update the headings to match? Also, the icons are currently centered which looks a bit weird: how about left alignment, as with the headings?

@ernestofgonzalez
Copy link
Contributor Author

If we're updating the icon colors, should we update the headings to match? Also, the icons are currently centered which looks a bit weird: how about left alignment, as with the headings?

Yeah, that'd look better. I'll push another commit.

@ernestofgonzalez
Copy link
Contributor Author

I like it better this way. What do you think @stefanv?

@stefanv
Copy link
Contributor

stefanv commented Oct 28, 2022

That looks good! I see casestudies.css also custom specifies color. I recommend refactoring that into a variable that is reused elsewhere.

Actually, looking at the theme CSS you already have:

  --colorPrimaryDark:  rgb(1, 50, 67);

which you can reuse as:

color: var(--colorPrimaryDark);

@ernestofgonzalez
Copy link
Contributor Author

That looks good! I see casestudies.css also custom specifies color. I recommend refactoring that into a variable that is reused elsewhere.

Actually, looking at the theme CSS you already have:

  --colorPrimaryDark:  rgb(1, 50, 67);

which you can reuse as:

color: var(--colorPrimaryDark);

Right! I missed that.
Done for case studies.css and tabs.css.
I see some usages of the hex color in layouts/shortcodes/numfocus.html. Want me to see if I can use the variable here?

@stefanv
Copy link
Contributor

stefanv commented Oct 29, 2022

Don't worry about the NF partial, I think this is good to go!

@stefanv stefanv merged commit 3d01e4c into numpy:main Oct 29, 2022
@ernestofgonzalez ernestofgonzalez deleted the sc-dom-imgs branch October 29, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Change icon colors in Science tab of Ecosystem section
2 participants