Skip to content

Change the color of the icons on the Scientific Domains tab #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Change the color of the icons on the Scientific Domains tab #479

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 15, 2021

I have changed the color of logos with HEX CODE #13243 under the main issue of #474 and further raised by @MarsBarLee.

Icon color was black, now looks like:

image

The SVG files were also reformatted across multiple lines for readability.

InessaPawson
InessaPawson approved these changes Oct 15, 2021
@InessaPawson InessaPawson self-requested a review October 15, 2021 22:28
Copy link
Member

@InessaPawson InessaPawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, Vivek! Keep going! There are 16 icons in the Scientific Domains subsection. It would be nice if you change the color in all of them.
CORRECTION: there are 14 icons in the Scientific Domains subsection.

Vivek Rai and others added 2 commits October 16, 2021 06:01
Add files via upload

Add files via upload

Add files via upload
@ghost
Copy link
Author

ghost commented Oct 16, 2021

@ghost
Copy link
Author

ghost commented Oct 16, 2021

in this directory : https://github.com/new-vivek11/numpy.org/tree/master/static/images/content_images/sc_dom_img

we have 15 files only - 14 of them are .svg files (whom i have modified in terms of color) and 1 file is a .py file which i did not change.

Not sure how to find the remaining 2 files of the 16 files (as mentioned above by @InessaPawson )

@ghost ghost requested a review from InessaPawson October 16, 2021 00:41
@InessaPawson
Copy link
Member

InessaPawson commented Oct 16, 2021

@new-vivek11 There are 14 icons indeed. It is all good to go now. Thank you!
We will merge your PR soon. (I don't have the push access to this repo.)

@ghost
Copy link
Author

ghost commented Oct 16, 2021

It's always great to see one's first PR merged ! 🌻

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice improvement in visual style to me, thanks @new-vivek11. Note that I have edited your PR description so it's clearer what this PR changes.

The other change of spreading the SVG file across multiple lines for readability seems fine with me as well. I don't work with design tools though, so no idea what the pros and cons are.

I think this is good to go, but would be nice to have @MarsBarLee have a look - so let's leave this open for a couple of days.

@rgommers rgommers changed the title Changed logos of Science Tab Changed color of logos on Scientific Domains tab Oct 17, 2021
@ghost
Copy link
Author

ghost commented Oct 17, 2021

@rgommers yes it will be good once she takes a look at it @MarsBarLee

@MarsBarLee
Copy link
Contributor

It looks great! I just have one issue: the icon for Graphs and Networks (sd6.svg) has a dark border around it.
This is how it looks in the PR:
image

This is how it looks usually, in the current numpy.org version:
image

(I also realized that this image is cropped- that can be fixed in a future PR)

I think the change to spreading the SVG file across multiple lines is due to Adobe Illustrator SVG Export Plug-In. It could help a future contributor read and change the SVG via code instead of a graphic program. For example, changing the color by changing 'stroke:#013243'.

@InessaPawson
Copy link
Member

... I just have one issue: the icon for Graphs and Networks (sd6.svg) has a dark border around it.

This is how it looks in the PR: image

This is how it looks in the [current numpy.org version].(https://github.com/numpy/numpy.org/blob/master/static/images/content_images/sc_dom_img/sd6.svg): image

@new-vivek11 Let me know if you need help fixing this issue.

@ghost
Copy link
Author

ghost commented Oct 23, 2021

I will look into it @InessaPawson and will give update on it soon.

@ghost
Copy link
Author

ghost commented Oct 23, 2021

@InessaPawson @MarsBarLee

I have changed the logo (sdg6.svg) .. look here : #483

@InessaPawson InessaPawson changed the title Changed color of logos on Scientific Domains tab Change the color of the icons on the Scientific Domains tab Oct 25, 2021
@InessaPawson InessaPawson mentioned this pull request Oct 25, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants