-
-
Notifications
You must be signed in to change notification settings - Fork 120
Change the color of the icons on the Scientific Domains tab #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, Vivek! Keep going! There are 16 icons in the Scientific Domains subsection. It would be nice if you change the color in all of them.
CORRECTION: there are 14 icons in the Scientific Domains subsection.
Add files via upload Add files via upload Add files via upload
@InessaPawson i have changed the color of all of them ! (See here : https://github.com/new-vivek11/numpy.org/tree/master/static/images/content_images/sc_dom_img) |
in this directory : https://github.com/new-vivek11/numpy.org/tree/master/static/images/content_images/sc_dom_img we have 15 files only - 14 of them are .svg files (whom i have modified in terms of color) and 1 file is a .py file which i did not change. Not sure how to find the remaining 2 files of the 16 files (as mentioned above by @InessaPawson ) |
@new-vivek11 There are 14 icons indeed. It is all good to go now. Thank you! |
It's always great to see one's first PR merged ! 🌻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice improvement in visual style to me, thanks @new-vivek11. Note that I have edited your PR description so it's clearer what this PR changes.
The other change of spreading the SVG file across multiple lines for readability seems fine with me as well. I don't work with design tools though, so no idea what the pros and cons are.
I think this is good to go, but would be nice to have @MarsBarLee have a look - so let's leave this open for a couple of days.
@rgommers yes it will be good once she takes a look at it @MarsBarLee |
It looks great! I just have one issue: the icon for Graphs and Networks (sd6.svg) has a dark border around it. This is how it looks usually, in the current numpy.org version: (I also realized that this image is cropped- that can be fixed in a future PR) I think the change to spreading the SVG file across multiple lines is due to Adobe Illustrator SVG Export Plug-In. It could help a future contributor read and change the SVG via code instead of a graphic program. For example, changing the color by changing 'stroke:#013243'. |
@new-vivek11 Let me know if you need help fixing this issue. |
I will look into it @InessaPawson and will give update on it soon. |
I have changed the logo (sdg6.svg) .. look here : #483 |
I have changed the color of logos with HEX CODE #13243 under the main issue of #474 and further raised by @MarsBarLee.
Icon color was black, now looks like:
The SVG files were also reformatted across multiple lines for readability.