Specify the color space in all new NumPy logo files #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InessaPawson
approved these changes
Feb 22, 2021
|
Great, thanks @isabela-pf and @InessaPawson! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of what is fixed or changed
Intended to fix #386. This changes color codes in both logo SVGs from hex color codes to
rgb()format equivalents.I wasn't totally clear if just changing the way color is defined in the SVG was the goal of the issue since all documentation I found and referenced in the issue said hex color codes and
rgb()were both considered sRBG. Please let me know if I've misinterpreted this issue and/or if other changes need to be made.If this works here, I'll go update the logo files and notes on the main NumPy repository as well which should close the issue. Thanks in advance for the review! 🌻