-
-
Notifications
You must be signed in to change notification settings - Fork 119
Add network/graph category to scientific domains tab #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks Jarrod. Having another look around for other packages that may deserve a mention, what do you think about these:
They all seem solid/popular/maintained, and it's not clear to me how they compare against graph-tool and PyGSP. |
NetworkX, graph-tool, igraph, NetworKit, snappy, scikit-network do network science: they are concerned with the analysis of networks. PyGSP, which stands for Graph Signal Processing, is more concerned with the analysis of data / features / signals supported by networks (as functions of vertices) and is closer to (spectral) graph theory. I have the following to say about the NetSci category:
I see two alternative categories depending on whether or not you want to take the alternative PyGSP point-of-view:
I'd vote for 2, but as the author of PyGSP I'm of course biased. |
Thanks for the thorough overview @mdeff
I'm happy to go with this option. "Graphs and Networks" does sound better to me. |
87d289e
to
0703ea8
Compare
I updated the PR to go with option 2. I also slightly changed the icon. I committed the script that generates it:
Feel free to change the colors, line thickess, or whatever. Or let me know if you want me to change something. Is there a better place to put the script? Should I take it out of the repo? |
I just looked #369 and noticed it looks like they got rid of the colors and the grays. I'll change the icon again. |
Adding the script next to the icon sounds fine to me. Would it be possible to make the png size smaller though @jarrodmillman? The new icon is 10x larger than the other icons, 250 kb is a lot for a small image. |
Why not export as SVG? Should be small given the small number of elements. I think they're moving to SVG in gh-369. |
I saved the icon as a SVG instead of a PNG. It is now 8.0K. I also made it 160px by 120px. I couldn't find any specification of the preferred size, so I just randomly selected one of the existing PNGs and used its width. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks @jarrodmillman!
Fixes gh-320. See #313 (comment).