Skip to content

ecosystem: remove 3D viz from domains? #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2020
Merged

ecosystem: remove 3D viz from domains? #318

merged 2 commits into from
Dec 27, 2020

Conversation

mdeff
Copy link
Contributor

@mdeff mdeff commented Jun 3, 2020

It's redundant to have 3D visualizations in scientific domains while there is a visualization tab (with a link to the comprehensive https://pyviz.org).

It's redundant to have 3D visualizations in scientific domains while
there is a visualization tab (with a link to the comprehensive
<https://pyviz.org>).
@mdeff
Copy link
Contributor Author

mdeff commented Jun 3, 2020

Also for consistency, as we don't have Machine Learning and Data Science in domains.

@rgommers
Copy link
Member

rgommers commented Jun 3, 2020

Fair enough, I agree that's better to remove. I had hoped that this would also make the spacing look better, because there's now seven entries in each row. It makes it look a bit worse though, on the left side:

image

I think that would be good to fix before merging this.

I don't really know right now what changes are needed for that; if you do that would be great, otherwise I can look into it later.

@mdeff
Copy link
Contributor Author

mdeff commented Jun 3, 2020

Well spotted. I think aligning topics vertically would be best, and the simplest fix would be to merge both rows in a single table. A downside is that there'll have to be holes if the number of topics is not even. I can do it if you agree that's the way to go.

@mdeff
Copy link
Contributor Author

mdeff commented Jun 3, 2020

20200603_172314

@mdeff
Copy link
Contributor Author

mdeff commented Jun 9, 2020

Can we merge this? I'd proceed with a PR for #319, #320, #321.

@rgommers
Copy link
Member

Sorry for the horrible delay in merging this @mdeff. I kind of ran out of time for working on the website. Christmas holiday allowed me to finally catch up with 2020 events.

@rgommers rgommers merged commit c63495a into numpy:master Dec 27, 2020
@mdeff
Copy link
Contributor Author

mdeff commented Dec 29, 2020

No problem @rgommers, you're doing a fantastic job.

@mdeff mdeff deleted the viz branch December 29, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants