Skip to content

DOC: Tighten ecosystem->data science per #242 #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bjnath
Copy link
Contributor

@bjnath bjnath commented May 23, 2020

Proposed edit per @rgommers comment in #242:
"Still would like to make this tab a little more compact."

Proposed edit per @rgommers comment in numpy#242:
"Still would like to make this tab a little more compact."
@rgommers
Copy link
Member

After this PR:

image

Compared to before:

image

This PR is closer to the amount of content we should keep; it removes a bunch of duplication and sticks to "one figure per tab" that I think we agreed somewhere else. It does end a bit abruptly. I'd like to keep DVC and MLFlow I think, because those are quite important but less well-known, so it helps teach people. I'll try to tweak this in a follow-up PR to better capture how broad the data science space is.

rgommers
rgommers previously approved these changes May 23, 2020
rgommers added a commit to rgommers/numpy.org that referenced this pull request May 23, 2020
Follow up to numpygh-242, alternative to numpygh-262. The content rewrite and
inclusion of more relevant libraries attempts to make this sound
natural, sketch the breadth of the Python data science offerings,
and keeps some of the tools like DVC and MLFlow that beginning to
intermediate data scientists really need to learn about.

It does shrink the amount of content to a more reasonable size.
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did leave out too much in the end, while not addressing a few of the issues in the existing content that I still wanted to address. So I submitted gh-272 as an alternative.

Your comments on that PR would be appreciated @bjnath. I noticed I couldn't tag you as a reviewer - I'll invite you to a NumPy team so that becomes possible, and will allow you to add labels, close issues, etc.

@rgommers rgommers dismissed their stale review May 23, 2020 21:29

see comment above

rgommers added a commit to rgommers/numpy.org that referenced this pull request May 24, 2020
Follow up to numpygh-242, alternative to numpygh-262. The content rewrite and
inclusion of more relevant libraries attempts to make this sound
natural, sketch the breadth of the Python data science offerings,
and keeps some of the tools like DVC and MLFlow that beginning to
intermediate data scientists really need to learn about.

It does shrink the amount of content to a more reasonable size.
@rgommers
Copy link
Member

Closed in favor of gh-272. Thanks @bjnath

@rgommers rgommers closed this May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants