Skip to content

Fixes #gh-223 color palette update as per #gh-33 in infographics for … #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2020

Conversation

shaloo
Copy link
Contributor

@shaloo shaloo commented May 9, 2020

…data science ecosystem tab

Brief description of what is fixed or changed

Deployed URL

http://numpy-<pr_number>.surge.sh/

@rgommers rgommers added the design label May 9, 2020
@rgommers
Copy link
Member

rgommers commented May 9, 2020

Thanks @shaloo. I like the new image, colors are much cleaner and layout improved as well:

image

I did notice that both images became way larger. Is it possible to shrink them a little, >1 MB each is a bit heavy.

@shaloo
Copy link
Contributor Author

shaloo commented May 11, 2020

Thanks @shaloo. I like the new image, colors are much cleaner and layout improved as well:

image

I did notice that both images became way larger. Is it possible to shrink them a little, >1 MB each is a bit heavy.

Good catch. Fixed image size. Also provided a way to click and view zoomed image (same image) Thanks.

@rgommers rgommers merged commit 4a5da4b into numpy:master May 11, 2020
@rgommers
Copy link
Member

LGTM now, merged. Thanks @shaloo!

@rgommers
Copy link
Member

One other question: what format are the originals in? It would be good to store those as well, in case we need to edit them in the future.

@shaloo
Copy link
Contributor Author

shaloo commented May 11, 2020

image format is png. The same image is linked for 'click-open-in-new tab' action. This one shows up image on full tab space of the browser window. So there is just 1 image.

@rgommers
Copy link
Member

But you can't edit these right? You must have made them in some drawing program, or Powerpoint/Keynote?

@shaloo
Copy link
Contributor Author

shaloo commented May 13, 2020

Oh I did not get your original query. Got it now. These pngs are generated using powerpoint. I have a full deck with all NumPy infographics generated so far. It is in pptx format. Where would you like me to check that it. It keeps getting updated/new-items-added periodically.

@rgommers
Copy link
Member

I think adding it to https://github.com/numpy/archive would be best. Big files that get updated are fine for that repo.

@shaloo
Copy link
Contributor Author

shaloo commented May 15, 2020

ok, will do that right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants