Skip to content

Sfork issu 182 #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

Sfork issu 182 #216

wants to merge 17 commits into from

Conversation

shaloo
Copy link
Contributor

@shaloo shaloo commented Apr 13, 2020

Brief description of what is fixed or changed

Deployed URL

http://numpy-<pr_number>.surge.sh/

@rossbar
Copy link
Contributor

rossbar commented Apr 13, 2020

@shaloo I'm happy to take a look, though it's quite difficult with the current diffs. Would it be possible to re-impose the 80-char line breaks as in #193? As it stands it's quite difficult to see and comment on the changes to the content.

@shaloo
Copy link
Contributor Author

shaloo commented Apr 14, 2020

@shaloo I'm happy to take a look, though it's quite difficult with the current diffs. Would it be possible to re-impose the 80-char line breaks as in #193? As it stands it's quite difficult to see and comment on the changes to the content.

Done, pls review. Thx.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates - lots of nice improvements!

I tried to make some suggestions to more concretely implement some of the comments I made in #182. One of the major comments that should be avoided is the concept that "scientists need visualization to comprehend the results", which appears in multiple locations in the case study. I tried to highlight and eliminate them where possible as this statement is a bit misleading.

Comment on lines +27 to +30
are ripples in the fabric of spacetime, generated by cataclysmic events in the
universe such as collision and merging of two black holes, coalescing binary
stars, supernovae or [compact
binaries](https://wwwmpa.mpa-garching.mpg.de/~hsr/researchcb-en.html). Observing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
are ripples in the fabric of spacetime, generated by cataclysmic events in the
universe such as collision and merging of two black holes, coalescing binary
stars, supernovae or [compact
binaries](https://wwwmpa.mpa-garching.mpg.de/~hsr/researchcb-en.html). Observing
are ripples in the fabric of spacetime, generated by phenomena such as
the merger of
[compact binaries](https://en.wikipedia.org/wiki/Compact_star) like
black holes or neutron stars. Observing

"phenomena" is arguably more appropriate than "cataclysmic events". Also, binary black holes are an example of compact binaries, so it's more concise to include them in that super-category.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also updated the link to wikipedia - the MPI link was not very detailed and (for me in the US at least) took a long time to load.

Comment on lines +32 to +40
obscure phenomena in the distant universe and its impact. Two of the most recent
events in the context of gravitaional waves are the focus of this case study:

* [GW observations from LIGO/Virgo
GW150914](https://en.wikipedia.org/wiki/First_observation_of_gravitational_waves):
The original discovery of gravitational waves from a binary black hole merger
* [GW observations from LiGO/Virgo
GW170817](https://en.wikipedia.org/wiki/GW170817): The first direct detection
of neutron start mergers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider moving the introduction of these particular GW events to a spot in the text after introducing LIGO. In my opinion, it flows better if the individual observations follow the introduction of the observatory(ies) itself.


The [Laser Interferometer Gravitational-Wave Observatory
(LIGO)](https://www.ligo.caltech.edu) was designed to open the field of
gravitational-wave astrophysics through the direct detection of gravitational
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gravitational-wave astrophysics through the direct detection of gravitational
gravitational-wave astronomy through the direct detection of gravitational

The original discovery of gravitational waves from a binary black hole merger
* [GW observations from LiGO/Virgo
GW170817](https://en.wikipedia.org/wiki/GW170817): The first direct detection
of neutron start mergers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of neutron start mergers
of a neutron star merger.

The [Laser Interferometer Gravitational-Wave Observatory
(LIGO)](https://www.ligo.caltech.edu) was designed to open the field of
gravitational-wave astrophysics through the direct detection of gravitational
waves predicted by Einstein’s General Theory of Relativity. It comprises two
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
waves predicted by Einstein’s General Theory of Relativity. It comprises two
waves predicted by Einstein’s general theory of relativity. It comprises two

This wasn't capitalized in the other case study. I think either is okay, but whichever convention is chosen, it should be consistent between the articles.

Comment on lines 145 to 148
* Data retrieval: Deciding which data can be analyzed, figuring out whether it
contains a signal - needle in a haystack
* Statistical analysis: estimate the statistical significance of observational
data, estimating the signal parameters (e.g. masses of stars, spin velocity,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These bullets seem incomplete - are they notes-to-self or intended to be included? If the latter, I think they need to be developed more, though I think the above bullet about GwPy and PyCBC adequately covers components like this.

Comment on lines 150 to 152
* Visualization of data
- Time series
- Spectrograms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

Comment on lines 156 to 157
GW detection has enabled researchers to discover entirely unexpected phenomena
while providing new insight into many of the most profound astrophysical
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GW detection has enabled researchers to discover entirely unexpected phenomena
while providing new insight into many of the most profound astrophysical
GW detection has enabled researchers to observe the universe in a brand new way,
providing new insight into many of the most profound astrophysical

Comment on lines +158 to +160
phenomena known. Number crunching and data visualization is a crucial step that
helps scientists gain insights into data gathered from the scientific
observations and understand the results. The computations are complex and cannot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
phenomena known. Number crunching and data visualization is a crucial step that
helps scientists gain insights into data gathered from the scientific
observations and understand the results. The computations are complex and cannot
phenomena known. Data analysis and visualization play a crucial role in
helping scientists interpret data gathered from the scientific
observations and communicate the results.

Comment on lines +161 to +162
be comprehended by humans unless it is visualized using computer simulations
that are fed with the real observed data and analysis. NumPy along with other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
be comprehended by humans unless it is visualized using computer simulations
that are fed with the real observed data and analysis. NumPy along with other
NumPy along with other

Again, this point is not correct.

@shaloo shaloo closed this Apr 20, 2020
@shaloo shaloo deleted the sfork-issu-182 branch April 20, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review of GWO Case Study
2 participants