Removes underline on nav link hover, updates hover color #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed. The orange isn't one of the theme colors, and the underline isn't really needed. So I think it's this color or a slightly darker blue. I'm happy with this change as is. Will leave it open for a bit in case @InessaPawson or @MarsBarLee want to weigh in. |
rgommers
approved these changes
Mar 30, 2020
|
Ah, gh-209 chances text of links here to dark blue, so light blue looks good in combination with that. |
|
Good idea, @joelachance! I prefer the Maximum Blue (#4dabcf) for the hover. |
InessaPawson
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a ticket, but I like this style for nav rollover a bit better. Previously we had the 'hugo-fresh' orange with underline. This removes the underline and updates the rollover color to the lighter NumPy blue. Open to suggestions!