Skip to content

Adds Google Analytics #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Adds Google Analytics #208

merged 1 commit into from
Mar 30, 2020

Conversation

joelachance
Copy link
Collaborator

Resolves #198. Attempted to test this, but I believe we'll need to test it at the numpy.org url.

@rgommers
Copy link
Member

Attempted to test this, but I believe we'll need to test it at the numpy.org url.

Yes I agree.

I quickly read up on synchronous vs. asynchronous tracking, looks like the latter only has advantages. So LGTM, merging. Thanks Joe!

@rgommers rgommers merged commit 521d587 into master Mar 30, 2020
@rgommers rgommers deleted the feature/198-ga branch March 30, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Analytics for numpy.org
2 participants